From: Jeff Garzik <jgarzik@pobox.com>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: linux-scsi@vger.kernel.org, linux1394-devel@lists.sourceforge.net
Subject: Re: host lock in EH
Date: Fri, 04 Nov 2005 23:55:53 -0500 [thread overview]
Message-ID: <436C3B59.7050202@pobox.com> (raw)
In-Reply-To: <436BFC3C.5030209@s5r6.in-berlin.de>
Stefan Richter wrote:
> Hi all,
>
> some time ago eh_device_reset_handlers of most drivers were changed to
> grab the host lock.
> http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=94d0e7b805961c44e4dc486ffc21075084bb7175
>
>
> Are there general reasons to acquire the host lock in eh_s?
The patch you reference simply maintains existing locking rules,
whatever they were at the time.
For drivers that unlocked the host lock and did their own thing, those
lock manipulations simply went away.
For drivers that took no locks, they were updated to take the host lock
since that is no longer done by the upper layers.
Jeff
-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42" plasma tv or your very own
Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php
prev parent reply other threads:[~2005-11-05 4:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-05 0:26 host lock in EH Stefan Richter
2005-11-05 4:55 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=436C3B59.7050202@pobox.com \
--to=jgarzik@pobox.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).