Re: [GIT PATCH] SCSI updates for 2.6.14

[Mike Christie <michaelc@cs.wisc.edu>]

Dave C Boutcher wrote:
> On Wed, Nov 09, 2005 at 05:09:11AM +0000, Christoph Hellwig wrote:
> 
>>On Tue, Nov 08, 2005 at 05:35:46PM -0600, Dave C Boutcher wrote:
>>
>>>On Sat, Nov 05, 2005 at 10:18:11AM -0600, James Bottomley wrote:
>>>
>>>>This is Part I of the pending SCSI patches (I still need to go over all
>>>>the flood that came in after 2.6.14 was declared).
>>>>
>>>>This patch is available from:
>>>>
>>>>master.kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-for-linus-2.6.git
>>>
>>>James, I note that my favorite masterpiece of ibmvscsis.c is not
>>>currently included.  Does that fall into part of the "flood"?
>>
>>it shouldn't go in.  we already have a version using the proper target
>>framework, that should be imroved upon to get production quality and then
>>merged.
> 
> 
> My only problem with that is the amount of time it is going to keep the
> driver out of the tree.  I'm happy to commit to merging to a converged
> infrastructure as soon as it is available.
> 

Your driver needs some work as it is. We are trying to kill scsi_request 
usage, your bio segments are wrong if cluster is not used (iscsi in 
mainline does not use clustering), and you could use bio_map_kern(). 
There are others, but I did not review it so closely.