public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: James Smart <james.smart@broadcom.com>
To: "Guilherme G. Piccoli" <gpiccoli@linux.vnet.ibm.com>,
	linux-scsi@vger.kernel.org
Cc: raphasil@linux.vnet.ibm.com, dick.kennedy@broadcom.com,
	jsmart2021@gmail.com, porcusbr@gmail.com
Subject: Re: [PATCH] scsi: lpfc: Fix crash on PCI hotplug remove path
Date: Wed, 31 May 2017 09:55:47 -0700	[thread overview]
Message-ID: <4389ae0e-98bd-441e-9768-231d9d31ca39@broadcom.com> (raw)
In-Reply-To: <ad52a01e-8b2c-6ca8-3d63-c76d9c144ba6@broadcom.com>

Actually, I think we solved this in a better manner in this patch in the 
11.4.0.0 patch set:
   PATCH 10/15] lpfc: Fix crash on powering off BFS VM with passthrough 
device
   http://marc.info/?l=linux-scsi&m=149621070910290&w=2

See if the above patch fixes your error.

-- james



On 5/29/2017 4:11 PM, James Smart wrote:
> looks good
>
> Signed-off-by: James Smart  <james.smart@broadcom.com>
>
> -- james
>
>
>
> On 5/28/2017 2:45 PM, Guilherme G. Piccoli wrote:
>> During a PCI hotplug remove event we could have a NULL pointer
>> dereference on lpfc_sli_abort_iocb(), if pring is NULL. This
>> patch adds a check for this case and is able to circumvent the
>> failure and continue the hotplug remove process with success.
>>
>> This issue was introduced after the driver refactor made on
>> commit 895427bd012c ("scsi: lpfc: NVME Initiator: Base modifications").
>>
>> Fixes: 895427bd012c ("scsi: lpfc: NVME Initiator: Base modifications")
>> Reported-by: Naresh Bannoth <nbannoth@in.ibm.com>
>> Signed-off-by: Guilherme G. Piccoli <gpiccoli@linux.vnet.ibm.com>
>> ---
>> This patch was rebased against Martin's 4.12/scsi-fixes.
>>
>>
>

      reply	other threads:[~2017-05-31 16:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-28 21:45 [PATCH] scsi: lpfc: Fix crash on PCI hotplug remove path Guilherme G. Piccoli
2017-05-29  7:56 ` Johannes Thumshirn
2017-05-29 21:32   ` Raphael Philipe Mendes da Silva
2017-05-29 23:11 ` James Smart
2017-05-31 16:55   ` James Smart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4389ae0e-98bd-441e-9768-231d9d31ca39@broadcom.com \
    --to=james.smart@broadcom.com \
    --cc=dick.kennedy@broadcom.com \
    --cc=gpiccoli@linux.vnet.ibm.com \
    --cc=jsmart2021@gmail.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=porcusbr@gmail.com \
    --cc=raphasil@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox