From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Jody McIntyre <scjody@modernduck.com>
Cc: linux1394-devel@lists.sourceforge.net,
Ben Collins <bcollins@debian.org>,
Andrew de Quincey <adq@lidskialf.net>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] sbp2: better check of transfer direction (protects from panic or oops)
Date: Fri, 09 Dec 2005 21:51:09 +0100 [thread overview]
Message-ID: <4399EE3D.60003@s5r6.in-berlin.de> (raw)
In-Reply-To: <20051209193423.GB19441@conscoop.ottawa.on.ca>
Jody McIntyre wrote:
> On Fri, Dec 09, 2005 at 08:01:11PM +0100, Stefan Richter wrote:
>>If all *known* paths are fixed, we could consider to override a bad
>>transfer direction silently like e.g. usb_storage does. But we should
>>not leave sbp2_create_command_orb() as fragile as it currently is.
>
> I didn't know USB did this.. the fact that USB checks itself suggests
> that we also need a check, and if we're checking we may as well warn.
Well, usb_storage actually does not override it explicitly. It just acts
only on DMA_FROM_DEVICE or DMA_TO_DEVICE after having first checked for
transfer buffer length AFAIU. However this is just one example. It
differs between SCSI low level drivers. I don't know if any of them logs
warnings about suspect transfer directions.
--
Stefan Richter
-=====-=-=-= ==-- -=--=
http://arcgraph.de/sr/
next prev parent reply other threads:[~2005-12-09 20:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200512082144.jB8Li6Ul022982@einhorn.in-berlin.de>
[not found] ` <20051209171922.GW19441@conscoop.ottawa.on.ca>
2005-12-09 19:01 ` [PATCH] sbp2: better check of transfer direction (protects from panic or oops) Stefan Richter
2005-12-09 19:34 ` Jody McIntyre
2005-12-09 20:51 ` Stefan Richter [this message]
2005-12-09 22:26 ` James Bottomley
2005-12-10 14:05 ` Stefan Richter
2005-12-10 18:21 ` Christoph Hellwig
2005-12-10 21:46 ` Douglas Gilbert
2005-12-10 23:13 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4399EE3D.60003@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=adq@lidskialf.net \
--cc=bcollins@debian.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=scjody@modernduck.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox