Re: linux kernel panic when ejecting ieee1394 ipod

Andrew de Quincey
2005-12-08T03:19:21Z

> [in sbp2_create_command_orb]
>
> > + /* check for duff DMA transfer direction with a zero length buffer */
> > + if (scsi_request_bufflen == 0)
> > + dma_dir = DMA_NONE;
>
> What if you replace WRITE by READ in
> drivers/scsi/scsi_ioctl.c::scsi_cmd_ioctl()::case CDROMEJECT ?

Yup, using READ there fixes it too (and I did remember to remove my other
patch before testing :)

USB storage devices still work with the CDROMEJECT ioctl and this change as
well.

> And BTW, can/should this latter case block be converted to use
> scsi_execute() or scsi_execute_req()?

Can't comment - don't know enough about the linux SCSI subsystem.