Re: linux kernel panic when ejecting ieee1394 ipod

Christoph Hellwig
2005-12-10T18:20:04Z

On Fri, Dec 09, 2005 at 05:45:22PM -0500, James Bottomley wrote:
> On Fri, 2005-12-09 at 20:35 +0100, Stefan Richter wrote:
> > When preparing a request in scsi_lib or in a SCSI high-level driver,
> > always set a transfer direction of DMA_NONE if data length is zero,
> > even for alleged write requests. (Extended patch derived from Jens
> > Axboe's version.)
> >
> > Write requests with request buffer length == 0 lead to kernel panic
> > or oops if channeled through sbp2:
> > http://marc.theaimsgroup.com/?l=linux1394-devel&m=113399994920181
> > http://marc.theaimsgroup.com/?l=linux1394-user&m=112152701817435
> >
> > Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
>
> The problem is that I already picked up Jens' patch in rc fixes, so this
> no-longer applies. However, given that the fix needed to be in four
> separate places, which looks rather bad, I propose the following
> consolidation instead.

Please make the export _GPL so people see it's internal and can go away
real soon. Hopefull for 2.6.16 already when Mike's patch series is merged.