From: Jeff Garzik <jgarzik@pobox.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] Move scsi_print_msg to SPI code
Date: Tue, 13 Dec 2005 13:32:45 -0500 [thread overview]
Message-ID: <439F13CD.8040602@pobox.com> (raw)
In-Reply-To: <20051213165342.GM9286@parisc-linux.org>
Matthew Wilcox wrote:
> scsi_print_msg got the transfer period translation to nanoseconds wrong.
> We have the right code to do this in scsi_transport_spi.c, but we can't
> guarantee that'll be linked in. scsi_print_msg is a bit of a misnomer
> anyway, since these messages are actually SPI messages, not SAM.
>
> So I've moved scsi_print_msg to scsi_transport_spi.c and renamed it to
> spi_print_msg. All drivers that use scsi_print_msg() got converted,
> and the Kconfig was adjusted to link in the SPI transport code for
> those drivers. Note that those drivers haven't been converted to use
> the SPI transport code ... but surely it's just a matter of time.
Strong ACK, though I think your change here should be split up: the
patch to link against SPI should be separated from the scsi_print_msg()
change.
This change will make it easier to start marginalizing SPI. Eventually
all SPI drivers will link against the SPI transport class, and this is
the necessary first step.
Jeff
next prev parent reply other threads:[~2005-12-13 18:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-13 16:53 [PATCH] Move scsi_print_msg to SPI code Matthew Wilcox
2005-12-13 18:32 ` Jeff Garzik [this message]
2005-12-15 20:58 ` Matthew Wilcox
2005-12-15 21:07 ` From: Matthew Wilcox <matthew@wil.cx> Matthew Wilcox
2005-12-15 21:07 ` Matthew Wilcox
2005-12-15 21:07 ` Matthew Wilcox
2005-12-15 21:07 ` Matthew Wilcox
2005-12-15 21:07 ` Matthew Wilcox
2005-12-15 21:22 ` [PATCH 4/5] [SCSI] Use ARRAY_SIZE in spi_print_msg Matthew Wilcox
2005-12-15 21:22 ` [PATCH 2/5] [SCSI] Rename scsi_print_msg to spi_print_msg Matthew Wilcox
2005-12-15 21:22 ` [PATCH 5/5] [SCSI] Add PPR support " Matthew Wilcox
2005-12-15 21:22 ` [PATCH 1/5] [SCSI] Move scsi_print_msg to SPI class Matthew Wilcox
2005-12-15 21:22 ` [PATCH 3/5] [SCSI] Fix printing of two-byte messages Matthew Wilcox
2005-12-15 21:22 ` [PATCH] Move scsi_print_msg to SPI code Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=439F13CD.8040602@pobox.com \
--to=jgarzik@pobox.com \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox