Re: [patch 6/6] statistics infrastructure - exploitation: zfcp

Christoph Hellwig
2005-12-14T16:59:02Z

> + atomic_t read_num;
> + atomic_t write_num;
> + struct statistic_interface *stat_if;
> + struct statistic *stat_sizes_scsi_write;
> + struct statistic *stat_sizes_scsi_read;
> + struct statistic *stat_sizes_scsi_nodata;
> + struct statistic *stat_sizes_scsi_nofit;
> + struct statistic *stat_sizes_scsi_nomem;
> + struct statistic *stat_sizes_timedout_write;
> + struct statistic *stat_sizes_timedout_read;
> + struct statistic *stat_sizes_timedout_nodata;
> + struct statistic *stat_latencies_scsi_write;
> + struct statistic *stat_latencies_scsi_read;
> + struct statistic *stat_latencies_scsi_nodata;
> + struct statistic *stat_pending_scsi_write;
> + struct statistic *stat_pending_scsi_read;
> + struct statistic *stat_erp;
> + struct statistic *stat_eh_reset;

NACK. pretty much all of this is generic and doesn't belong into an LLDD.
We already had this statistics things with emulex and they added various
bits to the core in response.