Re: [patch 6/6] statistics infrastructure - exploitation: zfcp

Heiko Carstens
2005-12-14T17:17:24Z

> >> if (device_register(&unit->sysfs_device)) {
> >>+ zfcp_unit_statistic_unregister(unit);
> >> kfree(unit);
> >> return NULL;
> >> }
> >> if (zfcp_sysfs_unit_create_files(&unit->sysfs_device)) {
> >>+ zfcp_unit_statistic_unregister(unit);
> >> device_unregister(&unit->sysfs_device);
> >> return NULL;
> >> }
> >Unrelated, but doesn't that error path forget to release unit?
>
> correct, I guess ... Andreas, could you fix this?

The release function frees the unit. Nothing to fix here.

Heiko