From: James Smart <James.Smart@Emulex.Com>
To: Mark Haverkamp <markh@osdl.org>
Cc: linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] lpfc: Timer fix
Date: Wed, 21 Dec 2005 12:39:29 -0500 [thread overview]
Message-ID: <43A99351.4090100@emulex.com> (raw)
In-Reply-To: <1134767813.5539.18.camel@markh1.pdx.osdl.net>
Agreed.
-- james s
Mark Haverkamp wrote:
> James,
>
> I've been doing some testing with the lpfc driver and started running
> into some BUG_ON problems using add_timer in lpfc_els_timeout_handler.
> I'm not certain, but I think that the add_timer call should be a
> mod_timer.
> Please take a look.
>
> Signed-of-by: Mark Haverkamp <markh@osdl.org>
>
> ---
>
> Index: scsi-misc-2.6/drivers/scsi/lpfc/lpfc_els.c
> ===================================================================
> --- scsi-misc-2.6.orig/drivers/scsi/lpfc/lpfc_els.c 2005-12-16 13:14:37.000000000 -0800
> +++ scsi-misc-2.6/drivers/scsi/lpfc/lpfc_els.c 2005-12-16 13:14:53.000000000 -0800
> @@ -2935,8 +2935,7 @@
> lpfc_sli_release_iocbq(phba, piocb);
> }
> if (phba->sli.ring[LPFC_ELS_RING].txcmplq_cnt) {
> - phba->els_tmofunc.expires = jiffies + HZ * timeout;
> - add_timer(&phba->els_tmofunc);
> + mod_timer(&phba->els_tmofunc, jiffies + HZ * timeout);
> }
> spin_unlock_irq(phba->host->host_lock);
> }
>
next prev parent reply other threads:[~2005-12-21 17:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-16 21:16 [PATCH] lpfc: Timer fix Mark Haverkamp
2005-12-21 17:39 ` James Smart [this message]
2005-12-21 18:25 ` James Bottomley
2005-12-21 18:45 ` James Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43A99351.4090100@emulex.com \
--to=james.smart@emulex.com \
--cc=linux-scsi@vger.kernel.org \
--cc=markh@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox