From: James Smart <James.Smart@Emulex.Com>
To: Michael Reed <mdr@sgi.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
Jeremy Higdon <jeremy@sgi.com>,
"Moore, Eric Dean" <Eric.Moore@lsil.com>,
Gary Hagensen <gwh@sgi.com>
Subject: Re: [PATCH] mptfusion - fc transport attributes
Date: Tue, 27 Dec 2005 12:15:56 -0500 [thread overview]
Message-ID: <43B176CC.2040004@emulex.com> (raw)
In-Reply-To: <43A35892.8010802@sgi.com>
> +static void
> +mptfc_set_rport_loss_tmo(struct fc_rport *rport, uint32_t timeout)
> +{
> + if (timeout > 0)
> + rport->dev_loss_tmo = timeout;
> + else
> + rport->dev_loss_tmo = mptfc_dev_loss_tmo;
> +}
The only function of the if-test here is checking for 0 or >0, as
the fc transport ensures it is nothing else. What bothers me is
if the value is 0, then you are overriding it with the mptfc default
value without any warning or error report to the user.
Perhaps we should be dealing with a zero value differently in the transport.
The rest looks ok...
-- james s
next prev parent reply other threads:[~2005-12-27 17:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-17 0:15 [PATCH] mptfusion - fc transport attributes Michael Reed
2005-12-27 17:15 ` James Smart [this message]
2006-01-06 21:23 ` Michael Reed
2006-01-09 14:51 ` James Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43B176CC.2040004@emulex.com \
--to=james.smart@emulex.com \
--cc=Eric.Moore@lsil.com \
--cc=gwh@sgi.com \
--cc=jeremy@sgi.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mdr@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox