public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Mike Christie <michaelc@cs.wisc.edu>
To: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: scsi scan bug when peripheral qualifier of 3 is returned
Date: Wed, 04 Jan 2006 01:11:06 -0600	[thread overview]
Message-ID: <43BB750A.5050000@cs.wisc.edu> (raw)

It looks like in previous kernels scsi_scan_target would pass 
scsi_sequential_lun_scan BLIST_SPARSELUN.

         } else if (res == SCSI_SCAN_TARGET_PRESENT) {
                 /*
                  * There's a target here, but lun 0 is offline so we
                  * can't use the report_lun scan.  Fall back to a
                  * sequential lun scan with a bflags of SPARSELUN and
                  * a default scsi level of SCSI_2
                  */
                 scsi_sequential_lun_scan(starget, BLIST_SPARSELUN,


And in the current kernel we pass it bflags.

                         /*
                          * The REPORT LUN did not scan the target,
                          * do a sequential scan.
                          */
                         scsi_sequential_lun_scan(starget, bflags,


But for SCSI_SCAN_TARGET_PRESENT bflags is not set. Is the correct fix 
to move where bflagsp gets set in scsi_probe_and_add_lun so that it gets 
set for the SCSI_SCAN_TARGET_PRESENT case, or should __scsi_scan_target 
be passing scsi_sequential_lun_scan and possibly scsi_report_lun_scan 
some default bflags values?

             reply	other threads:[~2006-01-04  7:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-04  7:11 Mike Christie [this message]
2006-01-04 17:40 ` scsi scan bug when peripheral qualifier of 3 is returned Patrick Mansfield
2006-01-04 18:28   ` Mike Christie
2006-01-04 19:01     ` Patrick Mansfield
2006-01-04 20:31       ` Mike Christie
2006-01-04 22:25         ` Patrick Mansfield
2006-01-05 16:56           ` Mike Christie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43BB750A.5050000@cs.wisc.edu \
    --to=michaelc@cs.wisc.edu \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox