* [PATCH] fc transport: add permanent_port_name fc_host attribute
@ 2006-01-13 1:16 Andreas Herrmann
2006-01-13 13:35 ` James Smart
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Herrmann @ 2006-01-13 1:16 UTC (permalink / raw)
To: James Bottomley, James Smart; +Cc: Linux SCSI
This is a revised patch to add an attribute for the port_name of
the physical port.
Regards,
Andreas
fc transport: add permanent_port_name fc_host attribute
Add fc_host attribute permanent_port_name which is
used to show the port name of the primary port -
the port that initially logged into the fabric.
For a virtual port (registered via the primary port with
FDISC command) it is useful to know not only its (virtual)
port name but also the permanent port name.
Signed-off-by: Andreas Herrmann <aherrman@de.ibm.com>
---
drivers/scsi/scsi_transport_fc.c | 4 ++++
include/scsi/scsi_transport_fc.h | 4 ++++
2 files changed, 8 insertions(+), 0 deletions(-)
87f9f797aed03adf2109841290f15d74acbbe70b
diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c
index 685b997..625f4a6 100644
--- a/drivers/scsi/scsi_transport_fc.c
+++ b/drivers/scsi/scsi_transport_fc.c
@@ -295,6 +295,7 @@ static int fc_host_setup(struct transpor
*/
fc_host_node_name(shost) = -1;
fc_host_port_name(shost) = -1;
+ fc_host_permanent_port_name(shost) = -1;
fc_host_supported_classes(shost) = FC_COS_UNSPECIFIED;
memset(fc_host_supported_fc4s(shost), 0,
sizeof(fc_host_supported_fc4s(shost)));
@@ -795,6 +796,8 @@ static FC_CLASS_DEVICE_ATTR(host, suppor
fc_private_host_rd_attr_cast(node_name, "0x%llx\n", 20, unsigned long long);
fc_private_host_rd_attr_cast(port_name, "0x%llx\n", 20, unsigned long long);
+fc_private_host_rd_attr_cast(permanent_port_name, "0x%llx\n", 20,
+ unsigned long long);
fc_private_host_rd_attr(symbolic_name, "%s\n", (FC_SYMBOLIC_NAME_SIZE +1));
fc_private_host_rd_attr(maxframe_size, "%u bytes\n", 20);
fc_private_host_rd_attr(serial_number, "%s\n", (FC_SERIAL_NUMBER_SIZE +1));
@@ -1160,6 +1163,7 @@ fc_attach_transport(struct fc_function_t
count=0;
SETUP_HOST_ATTRIBUTE_RD(node_name);
SETUP_HOST_ATTRIBUTE_RD(port_name);
+ SETUP_HOST_ATTRIBUTE_RD(permanent_port_name);
SETUP_HOST_ATTRIBUTE_RD(supported_classes);
SETUP_HOST_ATTRIBUTE_RD(supported_fc4s);
SETUP_HOST_ATTRIBUTE_RD(symbolic_name);
diff --git a/include/scsi/scsi_transport_fc.h b/include/scsi/scsi_transport_fc.h
index 394f14a..cf3fec8 100644
--- a/include/scsi/scsi_transport_fc.h
+++ b/include/scsi/scsi_transport_fc.h
@@ -303,6 +303,7 @@ struct fc_host_attrs {
/* Fixed Attributes */
u64 node_name;
u64 port_name;
+ u64 permanent_port_name;
u32 supported_classes;
u8 supported_fc4s[FC_FC4_LIST_SIZE];
char symbolic_name[FC_SYMBOLIC_NAME_SIZE];
@@ -338,6 +339,8 @@ struct fc_host_attrs {
(((struct fc_host_attrs *)(x)->shost_data)->node_name)
#define fc_host_port_name(x) \
(((struct fc_host_attrs *)(x)->shost_data)->port_name)
+#define fc_host_permanent_port_name(x) \
+ (((struct fc_host_attrs *)(x)->shost_data)->permanent_port_name)
#define fc_host_supported_classes(x) \
(((struct fc_host_attrs *)(x)->shost_data)->supported_classes)
#define fc_host_supported_fc4s(x) \
@@ -426,6 +429,7 @@ struct fc_function_template {
/* host fixed attributes */
unsigned long show_host_node_name:1;
unsigned long show_host_port_name:1;
+ unsigned long show_host_permanent_port_name:1;
unsigned long show_host_supported_classes:1;
unsigned long show_host_supported_fc4s:1;
unsigned long show_host_symbolic_name:1;
--
0.99.9n-g5a22
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fc transport: add permanent_port_name fc_host attribute
2006-01-13 1:16 [PATCH] fc transport: add permanent_port_name fc_host attribute Andreas Herrmann
@ 2006-01-13 13:35 ` James Smart
0 siblings, 0 replies; 2+ messages in thread
From: James Smart @ 2006-01-13 13:35 UTC (permalink / raw)
To: Andreas Herrmann; +Cc: James Bottomley, Linux SCSI
Looks Good :) Thanks for reposting.
-- james s
Andreas Herrmann wrote:
> This is a revised patch to add an attribute for the port_name of
> the physical port.
>
>
> Regards,
>
> Andreas
>
>
> fc transport: add permanent_port_name fc_host attribute
>
> Add fc_host attribute permanent_port_name which is
> used to show the port name of the primary port -
> the port that initially logged into the fabric.
>
> For a virtual port (registered via the primary port with
> FDISC command) it is useful to know not only its (virtual)
> port name but also the permanent port name.
>
> Signed-off-by: Andreas Herrmann <aherrman@de.ibm.com>
>
> ---
>
> drivers/scsi/scsi_transport_fc.c | 4 ++++
> include/scsi/scsi_transport_fc.h | 4 ++++
> 2 files changed, 8 insertions(+), 0 deletions(-)
>
> 87f9f797aed03adf2109841290f15d74acbbe70b
> diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c
> index 685b997..625f4a6 100644
> --- a/drivers/scsi/scsi_transport_fc.c
> +++ b/drivers/scsi/scsi_transport_fc.c
> @@ -295,6 +295,7 @@ static int fc_host_setup(struct transpor
> */
> fc_host_node_name(shost) = -1;
> fc_host_port_name(shost) = -1;
> + fc_host_permanent_port_name(shost) = -1;
> fc_host_supported_classes(shost) = FC_COS_UNSPECIFIED;
> memset(fc_host_supported_fc4s(shost), 0,
> sizeof(fc_host_supported_fc4s(shost)));
> @@ -795,6 +796,8 @@ static FC_CLASS_DEVICE_ATTR(host, suppor
>
> fc_private_host_rd_attr_cast(node_name, "0x%llx\n", 20, unsigned long long);
> fc_private_host_rd_attr_cast(port_name, "0x%llx\n", 20, unsigned long long);
> +fc_private_host_rd_attr_cast(permanent_port_name, "0x%llx\n", 20,
> + unsigned long long);
> fc_private_host_rd_attr(symbolic_name, "%s\n", (FC_SYMBOLIC_NAME_SIZE +1));
> fc_private_host_rd_attr(maxframe_size, "%u bytes\n", 20);
> fc_private_host_rd_attr(serial_number, "%s\n", (FC_SERIAL_NUMBER_SIZE +1));
> @@ -1160,6 +1163,7 @@ fc_attach_transport(struct fc_function_t
> count=0;
> SETUP_HOST_ATTRIBUTE_RD(node_name);
> SETUP_HOST_ATTRIBUTE_RD(port_name);
> + SETUP_HOST_ATTRIBUTE_RD(permanent_port_name);
> SETUP_HOST_ATTRIBUTE_RD(supported_classes);
> SETUP_HOST_ATTRIBUTE_RD(supported_fc4s);
> SETUP_HOST_ATTRIBUTE_RD(symbolic_name);
> diff --git a/include/scsi/scsi_transport_fc.h b/include/scsi/scsi_transport_fc.h
> index 394f14a..cf3fec8 100644
> --- a/include/scsi/scsi_transport_fc.h
> +++ b/include/scsi/scsi_transport_fc.h
> @@ -303,6 +303,7 @@ struct fc_host_attrs {
> /* Fixed Attributes */
> u64 node_name;
> u64 port_name;
> + u64 permanent_port_name;
> u32 supported_classes;
> u8 supported_fc4s[FC_FC4_LIST_SIZE];
> char symbolic_name[FC_SYMBOLIC_NAME_SIZE];
> @@ -338,6 +339,8 @@ struct fc_host_attrs {
> (((struct fc_host_attrs *)(x)->shost_data)->node_name)
> #define fc_host_port_name(x) \
> (((struct fc_host_attrs *)(x)->shost_data)->port_name)
> +#define fc_host_permanent_port_name(x) \
> + (((struct fc_host_attrs *)(x)->shost_data)->permanent_port_name)
> #define fc_host_supported_classes(x) \
> (((struct fc_host_attrs *)(x)->shost_data)->supported_classes)
> #define fc_host_supported_fc4s(x) \
> @@ -426,6 +429,7 @@ struct fc_function_template {
> /* host fixed attributes */
> unsigned long show_host_node_name:1;
> unsigned long show_host_port_name:1;
> + unsigned long show_host_permanent_port_name:1;
> unsigned long show_host_supported_classes:1;
> unsigned long show_host_supported_fc4s:1;
> unsigned long show_host_symbolic_name:1;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-01-13 13:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-01-13 1:16 [PATCH] fc transport: add permanent_port_name fc_host attribute Andreas Herrmann
2006-01-13 13:35 ` James Smart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).