From: Mike Christie <michaelc@cs.wisc.edu>
To: Christoph Hellwig <hch@lst.de>
Cc: James.Bottomley@steeleye.com, Eric.Moore@lsil.com,
James.Smart@Emulex.Com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] remove target parent limitiation
Date: Fri, 13 Jan 2006 12:22:02 -0600 [thread overview]
Message-ID: <43C7EFCA.4020908@cs.wisc.edu> (raw)
In-Reply-To: <20060113180400.GA3509@lst.de>
Christoph Hellwig wrote:
> ===================================================================
> --- scsi-misc-2.6.orig/drivers/scsi/scsi_scan.c 2006-01-13 17:55:57.000000000 +0100
> +++ scsi-misc-2.6/drivers/scsi/scsi_scan.c 2006-01-13 18:26:17.000000000 +0100
> @@ -334,19 +334,6 @@
> struct scsi_target *starget;
> struct scsi_target *found_target;
>
> - /*
> - * Obtain the real parent from the transport. The transport
> - * is allowed to fail (no error) if there is nothing at that
> - * target id.
> - */
> - if (shost->transportt->target_parent) {
> - spin_lock_irqsave(shost->host_lock, flags);
> - parent = shost->transportt->target_parent(shost, channel, id);
> - spin_unlock_irqrestore(shost->host_lock, flags);
> - if (!parent)
> - return NULL;
> - }
Should we remove the target_parent callout from the trasnport_template
since it is no longer used or does it make sense to keep it as part of
the API?
next prev parent reply other threads:[~2006-01-13 18:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-13 18:04 [PATCH] remove target parent limitiation Christoph Hellwig
2006-01-13 18:22 ` Mike Christie [this message]
2006-01-13 18:24 ` Christoph Hellwig
2006-01-13 18:27 ` Mike Christie
-- strict thread matches above, loose matches on Subject: below --
2006-01-13 19:01 Moore, Eric
2006-01-13 19:37 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43C7EFCA.4020908@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=Eric.Moore@lsil.com \
--cc=James.Bottomley@steeleye.com \
--cc=James.Smart@Emulex.Com \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox