[PATCH 2/8] fusion - mptsas, increase discovery timout to 300 seconds

[PATCH 2/8] fusion - mptsas, increase discovery timout to 300 seconds

[Moore, Eric]

[-- Attachment #1: Type: text/plain, Size: 177 bytes --]

Increase the port enable timeout only for SAS from 30 to 300 seconds.
A customer request for the handling large topologies.

Signed-off-by: Eric Moore <Eric.Moore@lsil.com>

[-- Attachment #2: fusion-2-port-enable.patch --]
[-- Type: application/octet-stream, Size: 1110 bytes --]

diff -uarN b/drivers/message/fusion/mptbase.c a/drivers/message/fusion/mptbase.c
--- b/drivers/message/fusion/mptbase.c	2006-01-16 17:57:31.000000000 -0700
+++ a/drivers/message/fusion/mptbase.c	2006-01-16 18:13:40.000000000 -0700
@@ -2770,13 +2770,16 @@
 
 	/* RAID FW may take a long time to enable
 	 */
-	if ( (ioc->facts.ProductID & MPI_FW_HEADER_PID_PROD_MASK)
-			> MPI_FW_HEADER_PID_PROD_TARGET_SCSI ) {
-		rc = mpt_handshake_req_reply_wait(ioc, req_sz, (u32*)&port_enable,
-				reply_sz, (u16*)&reply_buf, 300 /*seconds*/, sleepFlag);
+	if (((ioc->facts.ProductID & MPI_FW_HEADER_PID_PROD_MASK)
+	    > MPI_FW_HEADER_PID_PROD_TARGET_SCSI) ||
+	    (ioc->bus_type == SAS)) {
+		rc = mpt_handshake_req_reply_wait(ioc, req_sz,
+		(u32*)&port_enable, reply_sz, (u16*)&reply_buf,
+		300 /*seconds*/, sleepFlag);
 	} else {
-		rc = mpt_handshake_req_reply_wait(ioc, req_sz, (u32*)&port_enable,
-				reply_sz, (u16*)&reply_buf, 30 /*seconds*/, sleepFlag);
+		rc = mpt_handshake_req_reply_wait(ioc, req_sz,
+		(u32*)&port_enable, reply_sz, (u16*)&reply_buf,
+		30 /*seconds*/, sleepFlag);
 	}
 	return rc;
 }

Re: [PATCH 2/8] fusion - mptsas, increase discovery timout to 300 seconds

[Douglas Gilbert]

Moore, Eric wrote:
> Increase the port enable timeout only for SAS from 30 to 300 seconds.
> A customer request for the handling large topologies.

Eric,
I have seen various reports concerning SAS HBAs taking
"forever" to initialize/discover (various HBA manufacturers,
various OSes). Perhaps you could enlighten me why these
timeouts need to be so large.

Also if a SAS domain does not contain a fanout expander,
doesn't that limit the domain to around 128 or 256
SCSI devices (sum of scsi initiator and target ports)?
If so, perhaps the timeout could be one of two values,
a larger value if a fanout expander was found in
the most recent discover process.

Doug Gilbert

RE: [PATCH 2/8] fusion - mptsas, increase discovery timout to 300 seconds

[Moore, Eric]

On Monday, January 16, 2006 8:45 PM, Douglas Gilbert wrote: 

> Moore, Eric wrote:
> > Increase the port enable timeout only for SAS from 30 to 
> 300 seconds.
> > A customer request for the handling large topologies.
> 
> Eric,
> I have seen various reports concerning SAS HBAs taking
> "forever" to initialize/discover (various HBA manufacturers,
> various OSes). Perhaps you could enlighten me why these
> timeouts need to be so large.

The timeout before was already 300 seconds when
there was Integrated RAID firmware detected.  We are not
changing that.  My request is for non-raid SAS firmware, 
which before was 30 seconds.  Some customers having several
expanders, devices, and external raid boxs, find that 30 
seconds is not enough time to complete discovery by the firwmare.
If discovery didn't complete in that small 30 second timeframe, 
the driver didn't load.

I'm not sure what reports your getting about discovery taking
forever.  Was that LSI SAS, or someone else's hardware. 
Please enlighten me on that.


> 
> Also if a SAS domain does not contain a fanout expander,
> doesn't that limit the domain to around 128 or 256
> SCSI devices (sum of scsi initiator and target ports)?
> If so, perhaps the timeout could be one of two values,
> a larger value if a fanout expander was found in
> the most recent discover process.
> 

This is firmware assist hardware.  The port enable is
done only when the driver loads.  From port enable, 
the discovery is done in the firmware.  From the driver side, 
we only know about sas topology once the firmware completed 
their discovery.  So I'm not sure how we would be able to 
set timeout for port enable before discovery.  Because before
that point, the device config pages would not be valid.


Eric Moore