From: Hannes Reinecke <hare@suse.de>
To: Arjan van de Ven <arjan@infradead.org>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 3/4] aic79xx: SLOWCRC fix
Date: Tue, 24 Jan 2006 10:57:35 +0100 [thread overview]
Message-ID: <43D5FA0F.6040901@suse.de> (raw)
In-Reply-To: <1138096403.2977.36.camel@laptopd505.fenrus.org>
Arjan van de Ven wrote:
> On Tue, 2006-01-24 at 10:44 +0100, Hannes Reinecke wrote:
>> /*
>> + * Slow down our CRC interval to be
>> + * compatible with packetized U320 devices
>> + * that can't handle a CRC at full speed
>> + */
>> + if (ahd->features & AHD_AIC79XXB_SLOWCRC) {
>> + con_opts |= ENSLOWCRC;
>> + }
>
> since this seems to be a device quirk, shouldn't this just be part of
> the scsi blacklist and have a quirk there? Maybe with a generic option
> to trigger that quirk as well rather than a per driver module one...
>
Errm.
blacklisting is for device only, not for HBAs, or?
This slowcrc is a fix for buggy adaptec hardware. Nothing to do with the
devices connected to it...
Cheers,
Hannes
--
Dr. Hannes Reinecke hare@suse.de
SuSE Linux Products GmbH S390 & zSeries
Maxfeldstraße 5 +49 911 74053 688
90409 Nürnberg http://www.suse.de
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2006-01-24 9:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-24 9:44 [PATCH 3/4] aic79xx: SLOWCRC fix Hannes Reinecke
2006-01-24 9:53 ` Arjan van de Ven
2006-01-24 9:57 ` Hannes Reinecke [this message]
2006-01-24 10:51 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43D5FA0F.6040901@suse.de \
--to=hare@suse.de \
--cc=arjan@infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox