From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: Dave Jones <davej@redhat.com>,
linux-scsi@vger.kernel.org, bcollins@debian.org
Subject: Re: sgpool-8 double free
Date: Mon, 20 Feb 2006 00:10:09 +0100 [thread overview]
Message-ID: <43F8FAD1.9060307@s5r6.in-berlin.de> (raw)
In-Reply-To: <43F8F807.30605@s5r6.in-berlin.de>
I wrote:
> James Bottomley wrote:
>> This is a characteristic trace for double done() on the same SCSI
>> command.
>
> Perhaps. OTOH, maybe there was indeed memory overwritten.
PS: I suspect sbp2 may indeed doubly call done() in corner cases:
http://bugzilla.kernel.org/show_bug.cgi?id=5998
However a double done() is extremely unlikely in the case reported by
Dave. AFAICS from the messages at
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=182005 , sbp2 does
not run any of the code code paths which lead to alternative routes to
done(), besides the normal command completion. (These routes are
FireWire bus reset handling and SCSI error handling. In theory these
routes cannot doubly call done() either...)
--
Stefan Richter
-=====-=-==- --=- =--==
http://arcgraph.de/sr/
prev parent reply other threads:[~2006-02-19 23:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-19 20:29 sgpool-8 double free Dave Jones
2006-02-19 21:56 ` James Bottomley
2006-02-19 22:58 ` Stefan Richter
2006-02-19 23:10 ` Stefan Richter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43F8FAD1.9060307@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=James.Bottomley@SteelEye.com \
--cc=bcollins@debian.org \
--cc=davej@redhat.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox