linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Reed <mdr@sgi.com>
To: James.Smart@Emulex.Com
Cc: Andrew Vasquez <andrew.vasquez@qlogic.com>,
	Linux-SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] fc_transport: stop creating duplicate rport entries.
Date: Tue, 21 Feb 2006 15:52:09 -0600	[thread overview]
Message-ID: <43FB8B89.3090702@sgi.com> (raw)
In-Reply-To: <43F332B2.4000901@emulex.com>



James Smart wrote:
> Good Catch!
> 
> -- james s
> 
> Andrew Vasquez wrote:
>> Current fc_transport consumers initially register rports
>> with an UNKNOWN role-state and follow-up with a call to
>> fc_remote_port_rolechg(). 

So, is the above sequence necessary?  Why not just register
the rport with appropriate role and state?  This is what
LSI fusion driver (mptfc) does.  "roles" has target and
initiator set.  (Is fusion broken?)

(Not saying the fix shouldn't be there.)

Mike

<...snip...>


  reply	other threads:[~2006-02-21 21:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-14 22:22 [PATCH] fc_transport: stop creating duplicate rport entries Andrew Vasquez
2006-02-15 13:54 ` James Smart
2006-02-21 21:52   ` Michael Reed [this message]
2006-02-21 22:07     ` Michael Reed
2006-02-21 22:11     ` James Smart
2006-02-24 23:37       ` Michael Reed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43FB8B89.3090702@sgi.com \
    --to=mdr@sgi.com \
    --cc=James.Smart@Emulex.Com \
    --cc=andrew.vasquez@qlogic.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).