public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Bernhard Kaindl <bk@suse.de>
Cc: Al Viro <viro@ftp.linux.org.uk>, Andrew Morton <akpm@osdl.org>,
	bcollins@debian.org, scjody@modernduck.com,
	linux1394-devel@lists.sourceforge.net,
	linux-scsi@vger.kernel.org,
	James Bottomley <James.Bottomley@SteelEye.com>
Subject: Re: Fw: [Bugme-new] [Bug 6114] New: Initio sbp2 causes: "slab error in cache_free_debugcheck(): cache `size-512(DMA)': double free, or memory outside" object was overwritten
Date: Wed, 22 Feb 2006 01:34:42 +0100	[thread overview]
Message-ID: <43FBB1A2.9030009@s5r6.in-berlin.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0602220041070.21474@jbgna.fhfr.qr>

Bernhard Kaindl wrote:
> I tested the current ieee1394 cumulative patch in -mm1 from
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16-rc4/2.6.16-rc4-mm1/broken-out/git-ieee1394.patch
> with my Initio and it still triggered the CONFIG_DEBUG_SLAB detector.

What I don't understand is why mode page 8 is still accessed in your 
log: http://bugzilla.kernel.org/attachment.cgi?id=7432&action=view
(Log lines "command: Mode Sense (10): 5a 00 08 00 00 00 00 00 d9 00", 
"SCSI transfer size = 17d9" --- yeah, into a 512 Bytes big buffer, "sda: 
got wrong page".) Could you please add a printk() or SBP2_INFO() within 
the if() clause of sbp2scsi_slave_alloc() to make sure it is entered? 
Could you also add the line
	SBP2_INFO("skip_ms_page_8 = %d", sdev->skip_ms_page_8);
before the return in sbp2scsi_slave_configure()? Not that your kernel 
looses the flag somewhere along the way...

> This patch from Al Viro fixed the slab message for me:
> 
> Re: TYPE_RBC cache fixes (sbp2.c affected)
> 2006-02-21 13:51
> http://sourceforge.net/mailarchive/message.php?msg_id=14879016
> 
> Bernhard
> --
> PS: My bug report for this was: http://bugzilla.kernel.org/show_bug.cgi?id=6114

Al's patch is certainly better since it adds checks to the actual 
affected code region, i.e. mode_sense handling in the SCSI layers. 
James, would you integrate this patch?

However sbp2 will keep some sort of skip_ms_page_8 blacklisting anyway 
because of different issues with other bridges.
-- 
Stefan Richter
-=====-=-==- --=- =-==-
http://arcgraph.de/sr/


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642

       reply	other threads:[~2006-02-22  0:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20060221040511.35b69d26.akpm@osdl.org>
     [not found] ` <43FB6545.8080103@s5r6.in-berlin.de>
     [not found]   ` <43FB67BD.7030101@s5r6.in-berlin.de>
     [not found]     ` <20060221134543.5f844d7c.akpm@osdl.org>
     [not found]       ` <43FB9FE5.8070309@s5r6.in-berlin.de>
     [not found]         ` <Pine.LNX.4.64.0602220041070.21474@jbgna.fhfr.qr>
2006-02-22  0:34           ` Stefan Richter [this message]
2006-02-22  1:29             ` Fw: [Bugme-new] [Bug 6114] New: Initio sbp2 causes: "slab error in cache_free_debugcheck(): cache `size-512(DMA)': double free, or memory outside" object was overwritten Al Viro
2006-02-22  6:05               ` Stefan Richter
2006-02-22  0:53 Douglas Gilbert
2006-02-22  1:20 ` Al Viro
2006-02-22  2:39   ` Douglas Gilbert
2006-02-22  3:25     ` Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43FBB1A2.9030009@s5r6.in-berlin.de \
    --to=stefanr@s5r6.in-berlin.de \
    --cc=James.Bottomley@SteelEye.com \
    --cc=akpm@osdl.org \
    --cc=bcollins@debian.org \
    --cc=bk@suse.de \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=scjody@modernduck.com \
    --cc=viro@ftp.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox