From: Bart Van Assche <bvanassche@acm.org>
To: Adrian Hunter <adrian.hunter@intel.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH v2 2/4] scsi: ufs: Fix handling of lrbp->cmd
Date: Wed, 24 May 2023 08:44:03 -0700 [thread overview]
Message-ID: <43fb8ad4-fb7f-d31c-91a0-a33c67c6fc04@acm.org> (raw)
In-Reply-To: <c0126a93-c34f-10ef-b050-2e34be420b16@intel.com>
On 5/24/23 05:21, Adrian Hunter wrote:
> Currently the reserved tag is not used for SCSI cmds but
> there is also a WARN_ON(lrbp->cmd) in ufshcd_exec_dev_cmd()
Hi Adrian,
Thanks for the review. I will change that WARN_ON() statement into
"lrbp->cmd = NULL" to make ufshcd_exec_dev_cmd() consistent with the
other functions that use the reserved slot.
Bart.
next prev parent reply other threads:[~2023-05-24 15:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 22:31 [PATCH v2 0/4] UFS host controller driver patches Bart Van Assche
2023-05-17 22:31 ` [PATCH v2 1/4] scsi: ufs: Increase the START STOP UNIT timeout from one to ten seconds Bart Van Assche
2023-05-17 22:31 ` [PATCH v2 2/4] scsi: ufs: Fix handling of lrbp->cmd Bart Van Assche
2023-05-24 12:21 ` Adrian Hunter
2023-05-24 15:44 ` Bart Van Assche [this message]
2023-05-17 22:31 ` [PATCH v2 3/4] scsi: ufs: Move ufshcd_wl_shutdown() Bart Van Assche
2023-05-24 12:45 ` Adrian Hunter
2023-05-17 22:31 ` [PATCH v2 4/4] scsi: ufs: Simplify driver shutdown Bart Van Assche
2023-05-24 12:48 ` Adrian Hunter
2023-05-22 19:39 ` [PATCH v2 0/4] UFS host controller driver patches Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43fb8ad4-fb7f-d31c-91a0-a33c67c6fc04@acm.org \
--to=bvanassche@acm.org \
--cc=adrian.hunter@intel.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).