From: Jeff Garzik <jeff@garzik.org>
To: Andrew Morton <akpm@osdl.org>
Cc: Ed Lin <ed.lin@promise.com>,
linux-scsi@vger.kernel.org, promise_linux@promise.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.16-rc6] Promise SuperTrak driver
Date: Tue, 14 Mar 2006 02:13:08 -0500 [thread overview]
Message-ID: <44166D04.3070100@garzik.org> (raw)
In-Reply-To: <20060313192042.56bf67b3.akpm@osdl.org>
Andrew Morton wrote:
> "Ed Lin" <ed.lin@promise.com> wrote:
>>I guess DMA_32BIT_MASK is OK?
>
>
> If that's semantically what the 0xffffffff means then yes.
It means "select lower 32 bits, because the other 32 bits are
elsewhere." Since its an arg to cpu_to_le32() I suppose there is an
implicit truncation in there, but I add such masking myself to my own
code. Makes it more clear to the reader what's going on, IMO.
Its not quite what DMA_32BIT_MASK intends, either, IMO.
Jeff
next prev parent reply other threads:[~2006-03-14 7:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-13 10:38 [PATCH 2.6.16-rc6] Promise SuperTrak driver Ed Lin
2006-03-14 3:20 ` Andrew Morton
2006-03-14 7:13 ` Jeff Garzik [this message]
2006-03-14 9:18 ` Arjan van de Ven
2006-03-14 9:27 ` Jeff Garzik
2006-03-14 9:40 ` Arjan van de Ven
2006-03-14 15:12 ` Bob Copeland
-- strict thread matches above, loose matches on Subject: below --
2006-03-13 13:17 Ed Lin
2006-03-13 22:41 Jeff Garzik
2006-03-13 23:42 ` Andrew Morton
2006-03-14 10:50 ` Jan-Benedict Glaw
2006-03-14 20:04 ` Matthew Wilcox
2006-03-16 23:55 ` Adrian Bunk
[not found] <NONAMEBSkcJse1fTvOS000001bc@nonameb.ptu.promise.com>
2006-03-16 5:11 ` Jeff Garzik
[not found] <NONAMEBK04QBh0TzlYb000006b5@nonameb.ptu.promise.com>
2006-03-31 15:21 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44166D04.3070100@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@osdl.org \
--cc=ed.lin@promise.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=promise_linux@promise.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).