From: Jeff Garzik <jeff@garzik.org>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Arjan van de Ven <arjan@infradead.org>,
Christoph Hellwig <hch@lst.de>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] move ->eh_strategy_handler to the transport class
Date: Sat, 01 Apr 2006 15:16:52 -0500 [thread overview]
Message-ID: <442EDFB4.4050201@garzik.org> (raw)
In-Reply-To: <442EDB68.2060707@s5r6.in-berlin.de>
Stefan Richter wrote:
> Arjan van de Ven wrote:
>> On Sat, 2006-04-01 at 19:21 +0200, Christoph Hellwig wrote:
>>> Overriding the whole EH code is a per-transport, not per-host thing.
>>> Move ->eh_strategy_handler to the transport class, same as
>>> ->eh_timed_out.
>>
>> I like it, nice cleanup and it's fundamentally the right place to do it
>
> BTW, why are there Scsi_Hosts in (s)ata drivers anyway instead of being
> hidden by libata? (Think of libata---or a transport class---as a layer.)
Because they shouldn't be hidden by libata. aic94xx hides it, which is
the wrong layering. Each libata driver is a first-class SCSI driver,
where a lot of the SCSI stuff is handled by common library functions.
Jeff
next prev parent reply other threads:[~2006-04-01 20:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-01 17:21 [PATCH] move ->eh_strategy_handler to the transport class Christoph Hellwig
2006-04-01 17:56 ` Arjan van de Ven
2006-04-01 19:58 ` Stefan Richter
2006-04-01 20:16 ` Jeff Garzik [this message]
2006-04-01 20:57 ` Arjan van de Ven
2006-04-01 18:10 ` Jeff Garzik
2006-04-01 19:23 ` James Bottomley
2006-04-01 19:27 ` Jeff Garzik
2006-04-03 10:44 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=442EDFB4.4050201@garzik.org \
--to=jeff@garzik.org \
--cc=arjan@infradead.org \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).