* Re: [PATCH 01/22] SCSI: Introduce scsi_req_abort_cmd (REPOST) [not found] <11473487901100-git-send-email-htejun@gmail.com> @ 2006-05-13 21:21 ` Jeff Garzik 2006-05-14 2:00 ` Luben Tuikov 2006-05-14 2:01 ` Luben Tuikov 1 sibling, 1 reply; 6+ messages in thread From: Jeff Garzik @ 2006-05-13 21:21 UTC (permalink / raw) To: Tejun Heo Cc: alan, axboe, albertcc, forrest.zhao, efalk, linux-ide, Luben Tuikov, SCSI Mailing List Tejun Heo wrote: > Introduce scsi_req_abort_cmd(struct scsi_cmnd *). > This function requests that SCSI Core start recovery for the > command by deleting the timer and adding the command to the eh > queue. It can be called by either LLDDs or SCSI Core. LLDDs who > implement their own error recovery MAY ignore the timeout event if > they generated scsi_req_abort_cmd. ACK... > 2dcc69f8559ce963d637e881ca168afd91ee2478 > diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c > index 73994e2..dae4f08 100644 > --- a/drivers/scsi/scsi.c > +++ b/drivers/scsi/scsi.c > @@ -720,6 +720,24 @@ void scsi_init_cmd_from_req(struct scsi_ > static DEFINE_PER_CPU(struct list_head, scsi_done_q); > > /** > + * scsi_req_abort_cmd -- Request command recovery for the specified command > + * cmd: pointer to the SCSI command of interest > + * > + * This function requests that SCSI Core start recovery for the > + * command by deleting the timer and adding the command to the eh > + * queue. It can be called by either LLDDs or SCSI Core. LLDDs who > + * implement their own error recovery MAY ignore the timeout event if > + * they generated scsi_req_abort_cmd. > + */ > +void scsi_req_abort_cmd(struct scsi_cmnd *cmd) > +{ > + if (!scsi_delete_timer(cmd)) > + return; > + scsi_times_out(cmd); > +} > +EXPORT_SYMBOL(scsi_req_abort_cmd); > + > +/** > * scsi_done - Enqueue the finished SCSI command into the done queue. > * @cmd: The SCSI Command for which a low-level device driver (LLDD) gives > * ownership back to SCSI Core -- i.e. the LLDD has finished with it. > diff --git a/include/scsi/scsi_cmnd.h b/include/scsi/scsi_cmnd.h > index 1ace1b9..88c6c4d 100644 > --- a/include/scsi/scsi_cmnd.h > +++ b/include/scsi/scsi_cmnd.h > @@ -151,5 +151,6 @@ extern struct scsi_cmnd *scsi_get_comman > extern void scsi_put_command(struct scsi_cmnd *); > extern void scsi_io_completion(struct scsi_cmnd *, unsigned int, unsigned int); > extern void scsi_finish_command(struct scsi_cmnd *cmd); > +extern void scsi_req_abort_cmd(struct scsi_cmnd *cmd); > > #endif /* _SCSI_SCSI_CMND_H */ Patch quoted in its entirety, since this copy wasn't CC'd to linux-scsi. Jeff ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 01/22] SCSI: Introduce scsi_req_abort_cmd (REPOST) 2006-05-13 21:21 ` [PATCH 01/22] SCSI: Introduce scsi_req_abort_cmd (REPOST) Jeff Garzik @ 2006-05-14 2:00 ` Luben Tuikov 0 siblings, 0 replies; 6+ messages in thread From: Luben Tuikov @ 2006-05-14 2:00 UTC (permalink / raw) To: Jeff Garzik, Tejun Heo Cc: alan, axboe, albertcc, forrest.zhao, efalk, linux-ide, Luben Tuikov, SCSI Mailing List --- Jeff Garzik <jgarzik@pobox.com> wrote: > Tejun Heo wrote: > > Introduce scsi_req_abort_cmd(struct scsi_cmnd *). > > This function requests that SCSI Core start recovery for the > > command by deleting the timer and adding the command to the eh > > queue. It can be called by either LLDDs or SCSI Core. LLDDs who > > implement their own error recovery MAY ignore the timeout event if > > they generated scsi_req_abort_cmd. > > ACK... > > > > 2dcc69f8559ce963d637e881ca168afd91ee2478 > > diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c > > index 73994e2..dae4f08 100644 > > --- a/drivers/scsi/scsi.c > > +++ b/drivers/scsi/scsi.c > > @@ -720,6 +720,24 @@ void scsi_init_cmd_from_req(struct scsi_ > > static DEFINE_PER_CPU(struct list_head, scsi_done_q); > > > > /** > > + * scsi_req_abort_cmd -- Request command recovery for the specified command > > + * cmd: pointer to the SCSI command of interest > > + * > > + * This function requests that SCSI Core start recovery for the > > + * command by deleting the timer and adding the command to the eh > > + * queue. It can be called by either LLDDs or SCSI Core. LLDDs who > > + * implement their own error recovery MAY ignore the timeout event if > > + * they generated scsi_req_abort_cmd. > > + */ > > +void scsi_req_abort_cmd(struct scsi_cmnd *cmd) > > +{ > > + if (!scsi_delete_timer(cmd)) > > + return; > > + scsi_times_out(cmd); > > +} > > +EXPORT_SYMBOL(scsi_req_abort_cmd); > > + > > +/** > > * scsi_done - Enqueue the finished SCSI command into the done queue. > > * @cmd: The SCSI Command for which a low-level device driver (LLDD) gives > > * ownership back to SCSI Core -- i.e. the LLDD has finished with it. > > diff --git a/include/scsi/scsi_cmnd.h b/include/scsi/scsi_cmnd.h > > index 1ace1b9..88c6c4d 100644 > > --- a/include/scsi/scsi_cmnd.h > > +++ b/include/scsi/scsi_cmnd.h > > @@ -151,5 +151,6 @@ extern struct scsi_cmnd *scsi_get_comman > > extern void scsi_put_command(struct scsi_cmnd *); > > extern void scsi_io_completion(struct scsi_cmnd *, unsigned int, unsigned int); > > extern void scsi_finish_command(struct scsi_cmnd *cmd); > > +extern void scsi_req_abort_cmd(struct scsi_cmnd *cmd); > > > > #endif /* _SCSI_SCSI_CMND_H */ > > Patch quoted in its entirety, since this copy wasn't CC'd to linux-scsi. No, the patch isn't quoted in its entirety. You deleted a bunch of lines. See my next email where I simply CC lsml, and don't delete any lines. Good luck, Luben ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 01/22] SCSI: Introduce scsi_req_abort_cmd (REPOST) [not found] <11473487901100-git-send-email-htejun@gmail.com> 2006-05-13 21:21 ` [PATCH 01/22] SCSI: Introduce scsi_req_abort_cmd (REPOST) Jeff Garzik @ 2006-05-14 2:01 ` Luben Tuikov 2006-05-14 2:04 ` Jeff Garzik 1 sibling, 1 reply; 6+ messages in thread From: Luben Tuikov @ 2006-05-14 2:01 UTC (permalink / raw) To: jgarzik, alan, axboe, albertcc, forrest.zhao, efalk, linux-ide Cc: Luben Tuikov, Tejun Heo, linux-scsi --- Tejun Heo <htejun@gmail.com> wrote: > Introduce scsi_req_abort_cmd(struct scsi_cmnd *). > This function requests that SCSI Core start recovery for the > command by deleting the timer and adding the command to the eh > queue. It can be called by either LLDDs or SCSI Core. LLDDs who > implement their own error recovery MAY ignore the timeout event if > they generated scsi_req_abort_cmd. > > First post: > http://marc.theaimsgroup.com/?l=linux-scsi&m=113833937421677&w=2 > > Signed-off-by: Luben Tuikov <ltuikov@yahoo.com> > > Signed-off-by: Tejun Heo <htejun@gmail.com> > > --- > > drivers/scsi/scsi.c | 18 ++++++++++++++++++ > include/scsi/scsi_cmnd.h | 1 + > 2 files changed, 19 insertions(+), 0 deletions(-) > > 2dcc69f8559ce963d637e881ca168afd91ee2478 > diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c > index 73994e2..dae4f08 100644 > --- a/drivers/scsi/scsi.c > +++ b/drivers/scsi/scsi.c > @@ -720,6 +720,24 @@ void scsi_init_cmd_from_req(struct scsi_ > static DEFINE_PER_CPU(struct list_head, scsi_done_q); > > /** > + * scsi_req_abort_cmd -- Request command recovery for the specified command > + * cmd: pointer to the SCSI command of interest > + * > + * This function requests that SCSI Core start recovery for the > + * command by deleting the timer and adding the command to the eh > + * queue. It can be called by either LLDDs or SCSI Core. LLDDs who > + * implement their own error recovery MAY ignore the timeout event if > + * they generated scsi_req_abort_cmd. > + */ > +void scsi_req_abort_cmd(struct scsi_cmnd *cmd) > +{ > + if (!scsi_delete_timer(cmd)) > + return; > + scsi_times_out(cmd); > +} > +EXPORT_SYMBOL(scsi_req_abort_cmd); > + > +/** > * scsi_done - Enqueue the finished SCSI command into the done queue. > * @cmd: The SCSI Command for which a low-level device driver (LLDD) gives > * ownership back to SCSI Core -- i.e. the LLDD has finished with it. > diff --git a/include/scsi/scsi_cmnd.h b/include/scsi/scsi_cmnd.h > index 1ace1b9..88c6c4d 100644 > --- a/include/scsi/scsi_cmnd.h > +++ b/include/scsi/scsi_cmnd.h > @@ -151,5 +151,6 @@ extern struct scsi_cmnd *scsi_get_comman > extern void scsi_put_command(struct scsi_cmnd *); > extern void scsi_io_completion(struct scsi_cmnd *, unsigned int, unsigned int); > extern void scsi_finish_command(struct scsi_cmnd *cmd); > +extern void scsi_req_abort_cmd(struct scsi_cmnd *cmd); > > #endif /* _SCSI_SCSI_CMND_H */ > -- > 1.2.4 Now that's the patch in its entirety, Jeff. Luben ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 01/22] SCSI: Introduce scsi_req_abort_cmd (REPOST) 2006-05-14 2:01 ` Luben Tuikov @ 2006-05-14 2:04 ` Jeff Garzik 2006-05-14 2:08 ` Luben Tuikov 0 siblings, 1 reply; 6+ messages in thread From: Jeff Garzik @ 2006-05-14 2:04 UTC (permalink / raw) To: ltuikov Cc: Tejun Heo, alan, axboe, albertcc, forrest.zhao, efalk, linux-ide, linux-scsi Luben Tuikov wrote: > Now that's the patch in its entirety, Jeff. > > Luben hehe, thanks Dad :) Jeff ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 01/22] SCSI: Introduce scsi_req_abort_cmd (REPOST) 2006-05-14 2:04 ` Jeff Garzik @ 2006-05-14 2:08 ` Luben Tuikov 2006-05-14 2:12 ` Jeff Garzik 0 siblings, 1 reply; 6+ messages in thread From: Luben Tuikov @ 2006-05-14 2:08 UTC (permalink / raw) To: Jeff Garzik Cc: Tejun Heo, alan, axboe, albertcc, forrest.zhao, efalk, linux-ide, linux-scsi --- Jeff Garzik <jgarzik@pobox.com> wrote: > Luben Tuikov wrote: > > Now that's the patch in its entirety, Jeff. > > > > Luben > > > hehe, thanks Dad :) It is not very nice to chop off the patch email which GIT generated, and then claim, as you did, that that was the whole thing, when it clearly it was not. Luben ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 01/22] SCSI: Introduce scsi_req_abort_cmd (REPOST) 2006-05-14 2:08 ` Luben Tuikov @ 2006-05-14 2:12 ` Jeff Garzik 0 siblings, 0 replies; 6+ messages in thread From: Jeff Garzik @ 2006-05-14 2:12 UTC (permalink / raw) To: ltuikov Cc: Tejun Heo, alan, axboe, albertcc, forrest.zhao, efalk, linux-ide, linux-scsi Luben Tuikov wrote: > --- Jeff Garzik <jgarzik@pobox.com> wrote: > >> Luben Tuikov wrote: >>> Now that's the patch in its entirety, Jeff. >>> >>> Luben >> >> hehe, thanks Dad :) > > It is not very nice to chop off the patch email which GIT generated, > and then claim, as you did, that that was the whole thing, when > it clearly it was not. Clearly, its a conspiracy. No one ever makes mistakes. Jeff ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2006-05-14 2:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <11473487901100-git-send-email-htejun@gmail.com>
2006-05-13 21:21 ` [PATCH 01/22] SCSI: Introduce scsi_req_abort_cmd (REPOST) Jeff Garzik
2006-05-14 2:00 ` Luben Tuikov
2006-05-14 2:01 ` Luben Tuikov
2006-05-14 2:04 ` Jeff Garzik
2006-05-14 2:08 ` Luben Tuikov
2006-05-14 2:12 ` Jeff Garzik
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).