From: Michael Reed <mdr@sgi.com>
To: James.Smart@Emulex.Com
Cc: linux-scsi@vger.kernel.org
Subject: Re: [REPOST #2][PATCH] update max sdev block limit
Date: Tue, 16 May 2006 15:55:15 -0500 [thread overview]
Message-ID: <446A3C33.6010300@sgi.com> (raw)
In-Reply-To: <1147810416.3634.0.camel@localhost.localdomain>
I like this.
Thanks,
Mike
James Smart wrote:
> Updated patch to address comments from Pat Mansfield and Michael Reed:
> Bumped max to 600 (10mins). Set default dev_loss_tmo to a value other
> than the max (30s).
> ----
> Updated patch to address comments from Andreas Herrman, who noted that
> the initialization, with the HZ, was inconsistent with its use in the
> FC transport.
> --
> This patch ups the maximum limit for how long an sdev is allowed to
> be blocked. Originally, the value was 60 seconds. However, we are aware
> of array failover and switch reboot times that can be as high
> as 90 seconds. We're proposing to change the max to 120 seconds.
>
> -- james s
>
>
> Signed-off-by: James Smart <James.Smart@emulex.com>
>
> diff -upNr a/drivers/scsi/scsi_priv.h b/drivers/scsi/scsi_priv.h
> --- a/drivers/scsi/scsi_priv.h 2006-05-10 11:36:25.000000000 -0400
> +++ b/drivers/scsi/scsi_priv.h 2006-05-16 13:55:45.000000000 -0400
> @@ -127,7 +127,7 @@ extern struct bus_type scsi_bus_type;
> * classes.
> */
>
> -#define SCSI_DEVICE_BLOCK_MAX_TIMEOUT (HZ*60)
> +#define SCSI_DEVICE_BLOCK_MAX_TIMEOUT 600 /* units in seconds */
> extern int scsi_internal_device_block(struct scsi_device *sdev);
> extern int scsi_internal_device_unblock(struct scsi_device *sdev);
>
> diff -upNr a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c
> --- a/drivers/scsi/scsi_transport_fc.c 2006-05-11 10:31:54.000000000 -0400
> +++ b/drivers/scsi/scsi_transport_fc.c 2006-05-16 13:57:55.000000000 -0400
> @@ -368,7 +368,7 @@ static DECLARE_TRANSPORT_CLASS(fc_rport_
> * should insulate the loss of a remote port.
> * The maximum will be capped by the value of SCSI_DEVICE_BLOCK_MAX_TIMEOUT.
> */
> -static unsigned int fc_dev_loss_tmo = SCSI_DEVICE_BLOCK_MAX_TIMEOUT;
> +static unsigned int fc_dev_loss_tmo = 60; /* seconds */
>
> module_param_named(dev_loss_tmo, fc_dev_loss_tmo, int, S_IRUGO|S_IWUSR);
> MODULE_PARM_DESC(dev_loss_tmo,
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
prev parent reply other threads:[~2006-05-16 20:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-16 20:13 [REPOST #2][PATCH] update max sdev block limit James Smart
2006-05-16 20:55 ` Michael Reed [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=446A3C33.6010300@sgi.com \
--to=mdr@sgi.com \
--cc=James.Smart@Emulex.Com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).