Re: [PATCH 1/6] mpt fusion - fibre channel target discovery prematurely terminates

[Michael Reed <mdr@sgi.com>]

Michael Reed wrote:
> 
> James Bottomley wrote:
>> On Thu, 2006-05-18 at 14:59 -0500, Michael Reed wrote:
>>> mpt_config() can return EAGAIN.  When this happens, fibre channel target
>>> discovery can prematurely terminate with fewer than the total number of
>>> targets discovered.  This patch detects EAGAIN and reschedules the scan
>>> work.
>>>
>>> Generally, this situation only occurs when the lsiutil program is being
>>> used to reset the board.
>> mpt_config() only returns EAGAIN when it's out of message frames.  That
>> should be a very transient condition, so if this rarely occurs anyway,
>> why not just put an msleep(10) on the condition and then retry?  It
>> would save all the requeue logic.
> 
> It's not so transient during reset processing.  I've measured 10 to
> 15 seconds of elapsed time.  But, it always eventually succeeds.

Well, I should have said that the event occurs with some regularity
during reset processing.  And that the duration of the EAGAIN response
is 10 to 15 seconds.  I'd rather reschedule than msleep.

Mike

> 
> Mike
> 
>> James
>>
>>
>