From: Mike Christie <michaelc@cs.wisc.edu>
To: Doug Maxey <dwm@bebe.enoyolf.org>
Cc: Ravi Anand <ravi.anand@qlogic.com>,
David Somayajulu <davidcs2005@gmail.com>,
Duane Grigsby <duane.grigsby@qlogic.com>,
linux-scsi@vger.kernel.org
Subject: Re: [RFC] qla4xxx: TODO for re-submission
Date: Mon, 12 Jun 2006 15:05:19 -0500 [thread overview]
Message-ID: <448DC8FF.5090008@cs.wisc.edu> (raw)
In-Reply-To: <20060612190431.846310@bebe.enoyolf.org>
Doug Maxey wrote:
>> What is the struct cleanup though? typedef->just struct usage?
>>
>
> mainly, yes.
Ok. I am fine if you want to do that. For iscsi_tcp and friends we fixed
this, but nobody ever said anything about the typedef usage during the
initial qla4xxx postings so I thought we had been overly careful/picky.
For scsi I never saw anyone complain about the single file issue either.
However for the netdev review it looks like the qlogic net driver got
that comment and the typedef one.
What about the mixed case variable names and other junk? Some people get
a way with them and others don't. For scsi is the policy to not be that
picky or did some drivers sneak in?
> do we need to track the sparse types (__le*) for device
> data?
>
Yeah I think so. I do not think you were CCd on the coding style todo.
Qlogic and I sometimes drop you form CCs and forget to add you back on
later. Sorry about that.
next prev parent reply other threads:[~2006-06-12 20:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-11 1:16 [RFC] qla4xxx: TODO for re-submission Doug Maxey
2006-06-12 16:49 ` Ravi Anand
2006-06-12 16:52 ` Mike Christie
2006-06-12 16:57 ` Ravi Anand
2006-06-12 19:08 ` Doug Maxey
2006-06-12 19:01 ` Doug Maxey
2006-06-12 17:43 ` Mike Christie
2006-06-12 17:44 ` Mike Christie
2006-06-12 19:04 ` Doug Maxey
2006-06-12 20:05 ` Mike Christie [this message]
2006-06-12 18:05 ` Mike Christie
2006-06-12 21:10 ` Ravi Anand
2006-06-12 21:35 ` Mike Christie
2006-06-12 22:35 ` Mike Christie
2006-06-12 22:50 ` Ravi Anand
2006-06-12 22:43 ` Ravi Anand
2006-06-13 3:30 ` Mike Christie
2006-06-13 3:48 ` Doug Maxey
2006-06-13 4:31 ` Jeff Garzik
2006-06-13 5:00 ` Doug Maxey
2006-06-13 12:16 ` berthiaume_wayne
2006-06-15 0:35 ` Ravi Anand
2006-06-15 0:43 ` Ravi Anand
2006-06-15 17:31 ` Mike Christie
-- strict thread matches above, loose matches on Subject: below --
2006-06-16 22:32 David Somayajulu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=448DC8FF.5090008@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=davidcs2005@gmail.com \
--cc=duane.grigsby@qlogic.com \
--cc=dwm@bebe.enoyolf.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ravi.anand@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).