Re: [PATCH] Print SCSI Inquiry data more compactly

[James Smart <James.Smart@Emulex.Com>]

I agree with Eddie's points, with another small recommendation:

scsi <2:0:1:0> x00:HP 18.2G:ATLAS10K3_18_SCA:HP05:02:

where x00 is byte 1 of the inquiry data - device type and qualifier.
Clarifies the H:C:T:L as well.

-- james

Eddie Williams wrote:
> Do you need the labels?  How about
> scsi 2:0:1:0:DASD:HP 18.2G:ATLAS10K3_18_SCA:HP05:02:
> 
> This keeps it short.  For those that are probably looking at this data
> the labels are not needed anyway.  It is easy to parse if someone wants.
> I used "DASD" just because that is what was referenced before.  I think
> I would prefer the number or "direct access" but either way I would not
> lose any sleep.
> 
> Eddie
> On Wed, 2006-06-21 at 10:50 -0600, Matthew Wilcox wrote:
>> On Wed, Jun 21, 2006 at 12:41:50PM -0400, Philip R. Auld wrote:
>>>>     scsi 2:0:1:0: Device: DASD HP 18.2G ATLAS10K3_18_SCA HP05 ANSI ver: 02
>>> Parsing this, (and the Matt's earlier version), there are 5 tokens
>>> there in the middle for 4 fields. How does one know what the vendor
>>> string is for example?
>> 1) This is not for parsing, it's informational for users.  Do tools
>> really still parse through /var/log/dmesg?
>>
>> 2) This information is available other ways, such as through sysfs and
>> procfs.
>>
>> 3) I know it's not obvious from the above example (damn HP firmware),
>> but these are actually fixed-size fields.  The first is 8 bytes, "HP 18.2G"
>> the second 16 bytes are "ATLAS10K3_18_SCA", the third is "HP05" and then
>> the ANSI ver is at the end.
>> -
>> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>