[RFC] [PATCH 0/7] requested for qla4xxx!!!

[RFC] [PATCH 0/7] requested for qla4xxx!!!

[Ravi Anand]

All,

Today in the following email thread , Mike Christie outlined the 
modifications that has been done to qla4xx driver from the last submission: 

> http://marc.theaimsgroup.com/?l=linux-scsi&m=115151443814051&w=2

Following up what he already pointed out, here's the latest
qla4xxx driver for submission-review which supports QLogic 
products based on ISP4010 and ISP4022.

Thanx to Doug Maxey for the cleaning up all the cruft
and making it more inline with linux style.
In addition to that we really appreciate Mike's work for doing the
modification to qla4xxx/iscsi-transport/open-iscsi. 

Major Changes from the last release are as follows :

 o Removal of the unused cruft ie unused structs/macros/functions/file etc.
 o All the typedef usage has been removed.
 o Fixed coding style.
 o Hook's into iscsi-transport class.
 o Added support for session block/unblock.
 o Hook's into open-iscsi framework: 
  	-Support tgt discovery's from iscsiadm using send targets.
	- Exposes the persistent targets.
 o Lun scanning in user space.
 o Bug fixes and other trivial changes.

The patchset has been broken down as follows :

 o Driver definitions
 o Initialization routines
 o OS integration 
 o ISR routines
 o Mailbox routines
 o Support routines
 o Driver Version

There are other stuff that need to be done :

 o Add support for sysfs attributes.
 o Userspace support for session creation/deletion for iscsi HBAs.
 o Add support for other discovery mode ie iSNS/SLP.

All the patches has been uploaded at the following URL:

	ftp://ftp.qlogic.com/outgoing/linux/iSCSI/upstream/5.00.05b6-k/

Complete driver package and the diff from previous submission for review
has also been uploaded at the above mentioned link.

Looking forward to comment's/feedback.

Regards,
Ravi Anand
QLogic Corp

Re: [RFC] [PATCH 0/7] requested for qla4xxx!!!

[Michael Tokarev]

[Sorry for repost: was typo in linux-scsi@vger
 email, and open-iscsi@ didn't accept email
 either, as it says "i'm not subscribed" (which
 isn't _entirely_ true ;)]

Ravi Anand wrote:
> All,
> 
> Today in the following email thread , Mike Christie outlined the 
> modifications that has been done to qla4xx driver from the last submission: 
> 
>> http://marc.theaimsgroup.com/?l=linux-scsi&m=115151443814051&w=2
[...]
> All the patches has been uploaded at the following URL:
>
> 	ftp://ftp.qlogic.com/outgoing/linux/iSCSI/upstream/5.00.05b6-k/
>
> Complete driver package and the diff from previous submission for review
> has also been uploaded at the above mentioned link.
[...]

Hi.

I'm not of much help in reviewing the code and/or making code
suggestions.  Instead, I'm trying to build the driver as we've
several new servers with ISP4010 adapters, which should work
somehow... ;)

Except of the obvious prob wrt ql4_netlink.h file which you
already fixed by subsequent patch.. well....

....Ok.  I'm new in this area (just joined open-iscsi list).
And my first question is: which [i]scsi implementation you
were used as a base for this driver?

I've tried against curren open-iscsi svn repo, against
scsi-misc kernel git tree, and against open-iscsi-1.0-485
tarball.  Whch all are mostly similar (in API anyway).
ql4 driver does not compile - even after "fixing" some
"missing" #includes (like iscsi_if.h defining most of
the ISCSI_* constants used in ql4_os.c), there are alot
of functions missing (iscsi_{add,remove,free}_session()
etc), undeclared structures used (*dscvr*) etc.

What was used as a base for the work?

And also -- how ql3 driver is related to this ql4 one?
Does it (ql4) require ql3 to be compiled/loaded as well?
(The question is because, as it seems, the card represents
as two PCI (sub)devices - one is ethernet controller and
another is "network controller", like this:

04:04.0 Ethernet controller: QLogic Corp. QLA3010 Network Adapter (rev 05)
04:04.1 Network controller: QLogic Corp. QLA4010 iSCSI TOE Adapter (rev 05)
)

Thanks.

/mjt

Re: [RFC] [PATCH 0/7] requested for qla4xxx!!!

[Mike Christie]

Michael Tokarev wrote:
> [Sorry for repost: was typo in linux-scsi@vger
>  email, and open-iscsi@ didn't accept email
>  either, as it says "i'm not subscribed" (which
>  isn't _entirely_ true ;)]
> 
> Ravi Anand wrote:
>> All,
>>
>> Today in the following email thread , Mike Christie outlined the 
>> modifications that has been done to qla4xx driver from the last submission: 
>>
>>> http://marc.theaimsgroup.com/?l=linux-scsi&m=115151443814051&w=2
> [...]
>> All the patches has been uploaded at the following URL:
>>
>> 	ftp://ftp.qlogic.com/outgoing/linux/iSCSI/upstream/5.00.05b6-k/
>>
>> Complete driver package and the diff from previous submission for review
>> has also been uploaded at the above mentioned link.
> [...]
> 
> Hi.
> 
> I'm not of much help in reviewing the code and/or making code
> suggestions.  Instead, I'm trying to build the driver as we've
> several new servers with ISP4010 adapters, which should work
> somehow... ;)
> 
> Except of the obvious prob wrt ql4_netlink.h file which you
> already fixed by subsequent patch.. well....
> 
> ....Ok.  I'm new in this area (just joined open-iscsi list).
> And my first question is: which [i]scsi implementation you
> were used as a base for this driver?
> 
> I've tried against curren open-iscsi svn repo, against
> scsi-misc kernel git tree, and against open-iscsi-1.0-485
> tarball.  Whch all are mostly similar (in API anyway).
> ql4 driver does not compile - even after "fixing" some
> "missing" #includes (like iscsi_if.h defining most of
> the ISCSI_* constants used in ql4_os.c), there are alot
> of functions missing (iscsi_{add,remove,free}_session()
> etc), undeclared structures used (*dscvr*) etc.

For the kernel code you need to get the scsi-misc tree (see
kernel.org/git for details). For the userspace tools you need the
open-iscsi.org svn tree with this patch

http://www.cs.wisc.edu/~michaelc/iscsi/open-iscsi/linux-scsi/tmp-qla4xxx-hook-into-userpace3.patch

For the userspace tools, we do not have the init scripts finished up so
you have to build the svn userspace tools, install them, then run

iscsid and iscsiadm by hand.

The iscsiadm command to run with qla4xxx is:

iscsiadm -m discovery -t st -a $host_no_of_qla4xxx_card -p
$discovery_address:$portal

Re: [RFC] [PATCH 0/7] requested for qla4xxx!!!

[Michael Tokarev]

Mike Christie wrote:
> Michael Tokarev wrote:
[]
[]
>> I've tried against curren open-iscsi svn repo, against
>> scsi-misc kernel git tree, and against open-iscsi-1.0-485
>> tarball.  Whch all are mostly similar (in API anyway).
>> ql4 driver does not compile - even after "fixing" some
>> "missing" #includes (like iscsi_if.h defining most of
>> the ISCSI_* constants used in ql4_os.c), there are alot
>> of functions missing (iscsi_{add,remove,free}_session()
>> etc), undeclared structures used (*dscvr*) etc.
> 
> For the kernel code you need to get the scsi-misc tree (see
> kernel.org/git for details). For the userspace tools you need the
> open-iscsi.org svn tree with this patch
> 
> http://www.cs.wisc.edu/~michaelc/iscsi/open-iscsi/linux-scsi/tmp-qla4xxx-hook-into-userpace3.patch

Aha!  Here we go: that's the missing decls.
As I mentioned (above), I've already tried scsi-misc tree, and
open-iscsi svn - the patch above "fixes" the rest of the probs
during compilation (after fixing obvious probs in ql4xx sources).
Ok, that's.. umm.. not obvious at all that the patch above is
needed, and where to find it ;)



> For the userspace tools, we do not have the init scripts finished up so
> you have to build the svn userspace tools, install them, then run

That's no problem at all.  But thanks (or maybe not? -- you save me from
reading the docs (aka "RTFM"), which might be not that bad really - I mean,
reading them sometimes helps ;)

Building the modules and tools now...  Thanks for the pointers and the
explanation!

/mjt

Re: [RFC] [PATCH 0/7] requested for qla4xxx!!!

[Or Gerlitz]

Mike Christie wrote:
> For the kernel code you need to get the scsi-misc tree (see
> kernel.org/git for details). For the userspace tools you need the
> open-iscsi.org svn tree with this patch


> http://www.cs.wisc.edu/~michaelc/iscsi/open-iscsi/linux-scsi/tmp-qla4xxx-hook-into-userpace3.patch

Mike,

This URL gives me access denied error, i guess its not personal...

Or.

Re: [RFC] [PATCH 0/7] requested for qla4xxx!!!

[Mike Christie]

Or Gerlitz wrote:
> Mike Christie wrote:
>> For the kernel code you need to get the scsi-misc tree (see
>> kernel.org/git for details). For the userspace tools you need the
>> open-iscsi.org svn tree with this patch
> 
> 
>> http://www.cs.wisc.edu/~michaelc/iscsi/open-iscsi/linux-scsi/tmp-qla4xxx-hook-into-userpace3.patch
> 
> Mike,
> 
> This URL gives me access denied error, i guess its not personal...
> 
> Or.
> 

I can access it fine and have got reports others have as well. Are you
still having troubles? I sent the patch to the open-iscsi list

http://groups.google.com/group/open-iscsi/browse_frm/thread/193fe9037f3127da/5184ed1e2ba961b2#5184ed1e2ba961b2