From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Kyle McMartin <kyle@parisc-linux.org>
Cc: Rolf Eike Beer <eike-kernel@sf-tec.de>,
linux-scsi@vger.kernel.org,
James Bottomley <James.Bottomley@steeleye.com>
Subject: Re: [PATCH] Fix scsi/scsi_transport.h compile error
Date: Mon, 31 Jul 2006 17:26:18 +0200 [thread overview]
Message-ID: <44CE211A.2030205@s5r6.in-berlin.de> (raw)
In-Reply-To: <20060731143839.GC6087@athena.road.mcmartin.ca>
Kyle McMartin wrote:
> On Mon, Jul 31, 2006 at 03:37:46PM +0200, Stefan Richter wrote:
>> That function accesses members of the struct, i.e. the compiler needs to
>> know offsets into struct scsi_device at this point. Therefore it needs
>> the definition, not a declaration.
>
> Odd, ISTR that it only needed to be defined at the point the inline was
> used. Oh well, my bad.
One would think so. Maybe it depends on the compiler version.
(Actually I haven't checked scsi_transport.h myself but I recall fixing
another header with the same issue. Although I don't remember anymore
whether it lead to a warning or to an error and which gcc version I used
then.)
--
Stefan Richter
-=====-=-==- -=== ==---
http://arcgraph.de/sr/
next prev parent reply other threads:[~2006-07-31 15:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-31 7:43 [PATCH] Fix scsi/scsi_transport.h compile error Rolf Eike Beer
2006-07-31 13:14 ` Kyle McMartin
2006-07-31 13:37 ` Stefan Richter
2006-07-31 14:38 ` Kyle McMartin
2006-07-31 15:26 ` Stefan Richter [this message]
2006-08-01 6:10 ` Rolf Eike Beer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44CE211A.2030205@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=James.Bottomley@steeleye.com \
--cc=eike-kernel@sf-tec.de \
--cc=kyle@parisc-linux.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox