From: James Smart <James.Smart@Emulex.Com>
To: Rolf Eike Beer <eike-kernel@sf-tec.de>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/6] lpfc 8.1.7 : Adding statistics reset callback for FC transport
Date: Tue, 01 Aug 2006 09:40:34 -0400 [thread overview]
Message-ID: <44CF59D2.8050003@emulex.com> (raw)
In-Reply-To: <200608011414.51998.eike-kernel@sf-tec.de>
Rolf Eike Beer wrote:
>> -/* FIX ME */
>> - /*hs->SecondsSinceLastReset = (jiffies - lpfc_loadtime) / HZ;*/
>> + hs->seconds_since_last_reset = (jiffies - psli->stats_start) / HZ;
>
> Wraparound?
Ok - we should probably calculate it based on gettimeofday(). I'll update
and repost.
>> + memset(pmboxq, 0, sizeof (LPFC_MBOXQ_t));
> ^
>
> No space here.
Will include this too...
-- james
prev parent reply other threads:[~2006-08-01 13:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-01 11:33 [PATCH 1/6] lpfc 8.1.7 : Adding statistics reset callback for FC transport James Smart
2006-08-01 12:14 ` Rolf Eike Beer
2006-08-01 13:40 ` James Smart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44CF59D2.8050003@emulex.com \
--to=james.smart@emulex.com \
--cc=eike-kernel@sf-tec.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).