From: Jeff Garzik <jeff@garzik.org>
To: "Moore, Eric" <Eric.Moore@lsil.com>
Cc: James Bottomley <James.Bottomley@SteelEye.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 0/2] struct scsi_lun preparation
Date: Mon, 11 Sep 2006 17:41:51 -0400 [thread overview]
Message-ID: <4505D81F.5020300@garzik.org> (raw)
In-Reply-To: <664A4EBB07F29743873A87CF62C26D70307646@NAMAIL4.ad.lsil.com>
Moore, Eric wrote:
> On Monday, September 11, 2006 1:56 PM, Jeff Garzik wrote:
>
>>> A pretty print for the current u32 would be very useful though for
>>> transports dealing with non single level luns (or address
>> methods other
>>> than zero).
>> A better subject line would have been "HCIL isolation" I suppose. I
>> would like to see increased usage of the accessors already present in
>> include/scsi/scsi_device.h, which would ease the transition from
>> hardcoded HCIL struct members to a more flexible addressing method.
>>
>> Though, FWIW, for LUNs I would certainly like to see u64 rather than
>> u32.....
>>
>
> shouldn't luns be defined as:
>
> u8 lun[8] instead of u64?
Please, not that argument again :)
It's purely semantics, the same storage is used, and only very rarely
are the contents actually examined in either case.
Jeff
next prev parent reply other threads:[~2006-09-11 21:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-11 20:43 [PATCH 0/2] struct scsi_lun preparation Moore, Eric
2006-09-11 21:41 ` Jeff Garzik [this message]
2006-09-12 19:33 ` Luben Tuikov
2006-09-13 4:27 ` Douglas Gilbert
2006-09-12 19:21 ` Luben Tuikov
-- strict thread matches above, loose matches on Subject: below --
2006-09-11 14:34 Jeff Garzik
2006-09-11 17:29 ` James Bottomley
2006-09-11 19:55 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4505D81F.5020300@garzik.org \
--to=jeff@garzik.org \
--cc=Eric.Moore@lsil.com \
--cc=James.Bottomley@SteelEye.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox