Re: [PATCH 4/5] mvme147: Scsi_Cmnd to struct scsi_cmnd convertion

James Bottomley
2006-09-12T20:23:44Z

On Tue, 2006-09-12 at 20:31 +0200, Henne wrote:
> Changes obsolete typedef'd Scsi_Cmnd to struct scsi_cmnd.
> Signed-off-by: Henrik Kretzschmar <henne@nachtwindheim.de>

Actually, just a single patch for all the coupled drivers would be
better, please.

> -int wd33c93_queuecommand(Scsi_Cmnd *, void (*done)(Scsi_Cmnd *));
> -int wd33c93_abort(Scsi_Cmnd *);
> -int wd33c93_reset(Scsi_Cmnd *, unsigned int);
> +int wd33c93_queuecommand(struct scsi_cmnd *, void (*done)(struct scsi_cmnd *));
> +int wd33c93_abort(struct scsi_cmnd *);
> +int wd33c93_reset(struct scsi_cmnd *, unsigned int);

These prototypes are all unnecessary and can be pulled out of the
individual header files. The first two are provided by wd33c93.h and
the last one isn't actually in the body of any file.

wd33c93_info is also unused and can go.

Thanks,

James