Re: [patch 21/28] Signedness issue in drivers/scsi/ipr.c

Brian King
2006-09-26T13:10:44Z

ACK

akpm@osdl.org wrote:
> From: Eric Sesterhenn <snakebyte@gmx.de>
>
> gcc 4.1 with some extra warnings show the following:
>
> drivers/scsi/ipr.c:6361: warning: comparison of unsigned expression < 0 is always false
> drivers/scsi/ipr.c:6385: warning: comparison of unsigned expression < 0 is always false
> drivers/scsi/ipr.c:6415: warning: comparison of unsigned expression < 0 is always false
>
> The problem is that rc is of the type u32, which can never be smaller than
> zero, therefore all three error handling checks get useless. This patch
> changes it to a normal int, because all usages / all functions it get used
> with expect an int.
>
> Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
> Cc: James Bottomley <James.Bottomley@steeleye.com>
> Cc: Brian King <brking@us.ibm.com>
> Signed-off-by: Andrew Morton <akpm@osdl.org>
> ---
>
> drivers/scsi/ipr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN drivers/scsi/ipr.c~signedness-issue-in-drivers-scsi-iprc drivers/scsi/ipr.c
> --- a/drivers/scsi/ipr.c~signedness-issue-in-drivers-scsi-iprc
> +++ a/drivers/scsi/ipr.c
> @@ -6352,7 +6352,7 @@ static int __devinit ipr_probe_ioa(struc
> struct Scsi_Host *host;
> unsigned long ipr_regs_pci;
> void __iomem *ipr_regs;
> - u32 rc = PCIBIOS_SUCCESSFUL;
> + int rc = PCIBIOS_SUCCESSFUL;
> volatile u32 mask, uproc;
>
> ENTER;
> _
> -
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html

--
Brian King
eServer Storage I/O
IBM Linux Technology Center