From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [-mm patch] aic7xxx: check irq validity (was Re: 2.6.18-mm2) Date: Sun, 01 Oct 2006 15:19:30 -0400 Message-ID: <452014C2.1050000@garzik.org> References: <20060928014623.ccc9b885.akpm@osdl.org> <20060929155738.7076f0c8@werewolf> <20060929143949.GL5017@parisc-linux.org> <1159550143.13029.36.camel@localhost.localdomain> <20060929235054.GB2020@slug> <1159573404.13029.96.camel@localhost.localdomain> <20060930140946.GA1195@slug> <451F049A.1010404@garzik.org> <20061001142807.GD16272@parisc-linux.org> <1159729523.2891.408.camel@laptopd505.fenrus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:41874 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S932223AbWJATUI (ORCPT ); Sun, 1 Oct 2006 15:20:08 -0400 In-Reply-To: <1159729523.2891.408.camel@laptopd505.fenrus.org> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Arjan van de Ven Cc: Matthew Wilcox , linux-scsi@vger.kernel.org, "Linux-Kernel," , "J.A. Magall??n" , Alan Cox , Andrew Morton , Frederik Deweerdt Arjan van de Ven wrote: > well... why not go one step further and eliminate the flags argument > entirely? And use pci_name() for the name (so eliminate the argument ;) > and always pass pdev as data, so that that argument can go away too.... > > that'll cover 99% of the request_irq() users for pci devices.. and makes > it really nicely simple and consistent. Disagree. That would involve rewriting a lot of drivers. flags: may or may not need sample-random flag. name: is always the ethernet interface, for net drivers, or did you forget from your irqbalance days? ;-) data: in practice, is _rarely_ struct pci_dev. It's usually a driver-private structure which is the structure most frequently accessed. struct pci_dev* is rarely accessed inside the interrupt handler, except maybe somewhere deep in an error handling path. Jeff