Re: [PATCH 7/8] qla2xxx: Stall mid-layer error handlers while rport is blocked.

Patrick Mansfield
2006-10-10T15:13:35Z

On Fri, Oct 06, 2006 at 01:33:03PM -0400, James Smart wrote:

> I'm not seeing a win in offlining the device.
>
> >Maybe we need to fix up the SDEV_QUIESCE so we can do diagnostic IOs
> >with SG_IO. Userspace can at least set the device to this state and do
> >some tests but all other IO will not get through and the upper layers do
> >not have to do special things like set the device in READ only or set
> >the path state as failed.
> >
> >Or are you saying that even if we are able to relogin then there will be
> >problems that cannot be handled with the current tools? Something like
> >that one sense bug I was asking you about at OLS right? I am not sure
> >what to do with that?
>
> I'm questioning offlining, and wouldn't want to make a complicated
> recovery path.

I always thought the offlining was to protect *other* devices attached to
the HBA, so we don't repeatedly quiesce the entire HBA, and possibly reset
the target or HBA attached to the same LU that had a timed out command.

Then onlining in user space is not a problem as far as the given LU is
concerned.

Otherwise, I also can't think of a reason to offline the device.

-- Patrick Mansfield