Re: [PATCH] SCSI/qla2xxx: handle sysfs errors

Jeff Garzik
2006-10-12T17:20:41Z

Andrew Vasquez wrote:
> NACK, please don't do this. SYSFS entries, albiet important, aren't
> necessarilly critical to a functioning driver. I'd rather the driver
> not error out.

As discussed before, the only errors thrown are either ENOMEM or EFAULT,
both of which are quite serious.

> Here's what I had stewing to address the must_check directives and
> qla2xxx:

If you're gonna change it that much, might as well use attribute groups.

Jeff