* [PATCH 2.6.19-rc2] scsi: megaraid_{mm,mbox}: 64-bit DMA capability fix
@ 2006-10-16 8:08 Vasily Averin
2006-10-16 19:34 ` James Bottomley
0 siblings, 1 reply; 3+ messages in thread
From: Vasily Averin @ 2006-10-16 8:08 UTC (permalink / raw)
To: Linux Kernel Mailing List, linux-scsi, Ju, Seokmann,
James Bottomley, Andrew Morton, Linus Torvalds, devel
Cc: Andrey Mirkin
[-- Attachment #1: Type: text/plain, Size: 880 bytes --]
From: Andrey Mirkin (amirkin@sw.ru)
It is known that 2 LSI Logic MegaRAID SATA RAID Controllers (150-4 and 150-6)
don't support 64-bit DMA. Unfortunately currently this check is wrong and driver
sets 64-bit DMA mode for these devices.
Signed-off-by: Andrey Mirkin <amirkin@sw.ru>
Ack-by: Vasily Averin <vvs@sw.ru>
--- linux-2.6.19-rc2/drivers/scsi/megaraid/megaraid_mbox.c.mgst6 2006-10-16
10:26:50.000000000 +0400
+++ linux-2.6.19-rc2/drivers/scsi/megaraid/megaraid_mbox.c 2006-10-16
11:30:55.000000000 +0400
@@ -884,7 +884,7 @@ megaraid_init_mbox(adapter_t *adapter)
if (((magic64 == HBA_SIGNATURE_64_BIT) &&
((adapter->pdev->subsystem_device !=
- PCI_SUBSYS_ID_MEGARAID_SATA_150_6) ||
+ PCI_SUBSYS_ID_MEGARAID_SATA_150_6) &&
(adapter->pdev->subsystem_device !=
PCI_SUBSYS_ID_MEGARAID_SATA_150_4))) ||
(adapter->pdev->vendor == PCI_VENDOR_ID_LSI_LOGIC &&
[-- Attachment #2: diff-megaraid-sata1506-20061016 --]
[-- Type: text/plain, Size: 562 bytes --]
--- linux-2.6.19-rc2/drivers/scsi/megaraid/megaraid_mbox.c.mgst6 2006-10-16 10:26:50.000000000 +0400
+++ linux-2.6.19-rc2/drivers/scsi/megaraid/megaraid_mbox.c 2006-10-16 11:30:55.000000000 +0400
@@ -884,7 +884,7 @@ megaraid_init_mbox(adapter_t *adapter)
if (((magic64 == HBA_SIGNATURE_64_BIT) &&
((adapter->pdev->subsystem_device !=
- PCI_SUBSYS_ID_MEGARAID_SATA_150_6) ||
+ PCI_SUBSYS_ID_MEGARAID_SATA_150_6) &&
(adapter->pdev->subsystem_device !=
PCI_SUBSYS_ID_MEGARAID_SATA_150_4))) ||
(adapter->pdev->vendor == PCI_VENDOR_ID_LSI_LOGIC &&
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH 2.6.19-rc2] scsi: megaraid_{mm,mbox}: 64-bit DMA capability fix
@ 2006-10-16 12:32 Ju, Seokmann
0 siblings, 0 replies; 3+ messages in thread
From: Ju, Seokmann @ 2006-10-16 12:32 UTC (permalink / raw)
To: Vasily Averin, Linux Kernel Mailing List, linux-scsi,
James Bottomley, Andrew Morton, Linus Torvalds, devel
Cc: Andrey Mirkin
Hi,
Monday, October 16, 2006 4:09 AM, Vasily Averin wrote:
> It is known that 2 LSI Logic MegaRAID SATA RAID Controllers
> (150-4 and 150-6)
> don't support 64-bit DMA. Unfortunately currently this check
> is wrong and driver
> sets 64-bit DMA mode for these devices.
ACK - this patch will fix the problem.
Thank you for the finding, Vasily.
Seokmann
> -----Original Message-----
> From: Vasily Averin [mailto:vvs@sw.ru]
> Sent: Monday, October 16, 2006 4:09 AM
> To: Linux Kernel Mailing List; linux-scsi@vger.kernel.org;
> Ju, Seokmann; James Bottomley; Andrew Morton; Linus Torvalds;
> devel@openvz.org
> Cc: Andrey Mirkin
> Subject: [PATCH 2.6.19-rc2] scsi: megaraid_{mm,mbox}: 64-bit
> DMA capability fix
>
> From: Andrey Mirkin (amirkin@sw.ru)
>
> It is known that 2 LSI Logic MegaRAID SATA RAID Controllers
> (150-4 and 150-6)
> don't support 64-bit DMA. Unfortunately currently this check
> is wrong and driver
> sets 64-bit DMA mode for these devices.
>
> Signed-off-by: Andrey Mirkin <amirkin@sw.ru>
> Ack-by: Vasily Averin <vvs@sw.ru>
>
> ---
> linux-2.6.19-rc2/drivers/scsi/megaraid/megaraid_mbox.c.mgst6
> 2006-10-16
> 10:26:50.000000000 +0400
> +++ linux-2.6.19-rc2/drivers/scsi/megaraid/megaraid_mbox.c
> 2006-10-16
> 11:30:55.000000000 +0400
> @@ -884,7 +884,7 @@ megaraid_init_mbox(adapter_t *adapter)
>
> if (((magic64 == HBA_SIGNATURE_64_BIT) &&
> ((adapter->pdev->subsystem_device !=
> - PCI_SUBSYS_ID_MEGARAID_SATA_150_6) ||
> + PCI_SUBSYS_ID_MEGARAID_SATA_150_6) &&
> (adapter->pdev->subsystem_device !=
> PCI_SUBSYS_ID_MEGARAID_SATA_150_4))) ||
> (adapter->pdev->vendor == PCI_VENDOR_ID_LSI_LOGIC &&
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2.6.19-rc2] scsi: megaraid_{mm,mbox}: 64-bit DMA capability fix
2006-10-16 8:08 [PATCH 2.6.19-rc2] scsi: megaraid_{mm,mbox}: 64-bit DMA capability fix Vasily Averin
@ 2006-10-16 19:34 ` James Bottomley
0 siblings, 0 replies; 3+ messages in thread
From: James Bottomley @ 2006-10-16 19:34 UTC (permalink / raw)
To: Vasily Averin
Cc: Linux Kernel Mailing List, linux-scsi, Ju, Seokmann,
Andrew Morton, Linus Torvalds, devel, Andrey Mirkin
On Mon, 2006-10-16 at 12:08 +0400, Vasily Averin wrote:
> It is known that 2 LSI Logic MegaRAID SATA RAID Controllers (150-4 and 150-6)
> don't support 64-bit DMA. Unfortunately currently this check is wrong and driver
> sets 64-bit DMA mode for these devices.
>
> Signed-off-by: Andrey Mirkin <amirkin@sw.ru>
> Ack-by: Vasily Averin <vvs@sw.ru>
>
> --- linux-2.6.19-rc2/drivers/scsi/megaraid/megaraid_mbox.c.mgst6 2006-10-16
> 10:26:50.000000000 +0400
> +++ linux-2.6.19-rc2/drivers/scsi/megaraid/megaraid_mbox.c 2006-10-16
> 11:30:55.000000000 +0400
> @@ -884,7 +884,7 @@ megaraid_init_mbox(adapter_t *adapter)
>
> if (((magic64 == HBA_SIGNATURE_64_BIT) &&
> ((adapter->pdev->subsystem_device !=
> - PCI_SUBSYS_ID_MEGARAID_SATA_150_6) ||
> + PCI_SUBSYS_ID_MEGARAID_SATA_150_6) &&
> (adapter->pdev->subsystem_device !=
> PCI_SUBSYS_ID_MEGARAID_SATA_150_4))) ||
> (adapter->pdev->vendor == PCI_VENDOR_ID_LSI_LOGIC &&
Er ... this patch would apply in reverse, but what's in the tree
currently looks to be correct.
James
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-10-16 19:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-16 8:08 [PATCH 2.6.19-rc2] scsi: megaraid_{mm,mbox}: 64-bit DMA capability fix Vasily Averin
2006-10-16 19:34 ` James Bottomley
-- strict thread matches above, loose matches on Subject: below --
2006-10-16 12:32 Ju, Seokmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox