Re: [linux-usb-devel] Fw: garbled usb storage scsi vendor & model in 2.6.19-rc1

[Phil Dibowitz <phil@ipom.com>]

[-- Attachment #1: Type: text/plain, Size: 1158 bytes --]

Alan Stern wrote:
> There's a comment about this in the source code, asking what should be
> done if the INQUIRY response is too short (as it is here).  Maybe the best
> approach would be always to assume the first 36 bytes are valid, even when
> the device says they aren't.  It ought to solve your problem, and it's
> no worse than what we're doing now.
> 
> The patch is below.  This replaces the patch I sent earlier.

Perhaps a better approach might be to set the product and vendor to some
specific string if the device says it isn't providing one? In the new model,
can't we still have the chance of showing garbage if the device really isn't
setting anything useful? So what if we show "Unknown" and "Unknown" or
something similar in the event that the device sets the 'invalid' bit?

Just a thought...

-- 
Phil Dibowitz                             phil@ipom.com
Freeware and Technical Pages              Insanity Palace of Metallica
http://www.phildev.net/                   http://www.ipom.com/

"Be who you are and say what you feel, because those who mind don't matter
and those who matter don't mind."
 - Dr. Seuss



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]