Re: [PATCH] SCSI: ISCSI build failure

[Randy Dunlap <randy.dunlap@oracle.com>]

Matthew Wilcox wrote:
> On Thu, Nov 02, 2006 at 12:26:54AM +0900, James Bottomley wrote:
>> On Wed, 2006-11-01 at 01:00 +0100, Roman Zippel wrote:
>>> Please don't select NET, it's way too broad.
>> Then you'll make select implied dependencies work in Kbuild so we don't
>> need to do anything at all about this?

Roman said that CONFIG_NET is too broad to select,
and I agree with him.  Select is meant to be used to enable one
library-like kernel feature/function, not all of "Networking".

But yes, there do seem to be some depends/selects interaction
whose handling is missing.

> This is iSCSI ... how can it possibly be useful without NET?  Why
> doesn't CONFIG_ISCSI depend on NET, making this whole problem moot (for
> now).

There is no CONFIG_ISCSI symbol AFAIK.  I see:

CONFIG_SCSI_ISCSI_ATTRS
CONFIG_ISCSI_TCP
CONFIG_SCSI_QLA_ISCSI

If CONFIG_NET=n, CONFIG_SCSI_QLA_ISCSI can still be enabled
by a user and it will "select" CONFIG_SCSI_ISCSI_ATTRS.
SCSI_ISCSI_ATTRS depends on SCSI && NET, so there should be
some (either) depends or selects action going on there.  I think
we agree on that part at least.


-- 
~Randy
who still wishes that the SCSI low-level drivers menu were not in
some dog-awful random order