From: "Darrick J. Wong" <djwong@us.ibm.com>
To: linux-scsi <linux-scsi@vger.kernel.org>
Cc: Alexis Bruemmer <alexisb@us.ibm.com>
Subject: Re: [PATCH 3/4] aic94xx: cleanup after a discovery error
Date: Fri, 10 Nov 2006 16:45:47 -0800 [thread overview]
Message-ID: <45551D3B.7070007@us.ibm.com> (raw)
In-Reply-To: <1163102636.6521.19.camel@localhost.localdomain>
Alexis Bruemmer wrote:
> Domain device is freed but the port dev list is not adjusted on some
> discovery errors. Module unload will Oops if this happens.
It'll still oops; sas_ex_discover_end_dev needs to be updated to know
that it needn't call sas_rphy_free if the device-specific discovery
functions fail. This patch should fix that case too.
--
Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
diff --git a/drivers/scsi/libsas/sas_expander.c b/drivers/scsi/libsas/sas_expander.c
index 4cc7457..a38d05b 100644
--- a/drivers/scsi/libsas/sas_expander.c
+++ b/drivers/scsi/libsas/sas_expander.c
@@ -711,7 +711,6 @@ static struct domain_device *sas_ex_disc
out_list_del:
list_del(&child->dev_list_node);
- sas_rphy_free(rphy);
out_free:
sas_port_delete(phy->port);
out_err:
next prev parent reply other threads:[~2006-11-11 0:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-09 20:03 [PATCH 3/4] aic94xx: cleanup after a discovery error Alexis Bruemmer
2006-11-11 0:42 ` Darrick J. Wong
2006-11-11 0:45 ` Darrick J. Wong [this message]
2006-11-12 18:31 ` Darrick J. Wong
2006-11-11 0:48 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45551D3B.7070007@us.ibm.com \
--to=djwong@us.ibm.com \
--cc=alexisb@us.ibm.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox