From: Jeff Garzik <jeff@garzik.org>
To: "Darrick J. Wong" <djwong@us.ibm.com>
Cc: ltuikov@yahoo.com, mike.redan@bell.ca,
James.Bottomley@SteelEye.com, alexisb@us.ibm.com,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: Aic94xx and Linux kernel 2.6.19
Date: Sun, 12 Nov 2006 14:23:05 -0500 [thread overview]
Message-ID: <45577499.1010101@garzik.org> (raw)
In-Reply-To: <4557707B.8040701@us.ibm.com>
Darrick J. Wong wrote:
> diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
> index 7af2a4b..5c1fc46 100644
> --- a/drivers/ata/libata-scsi.c
> +++ b/drivers/ata/libata-scsi.c
> @@ -1612,9 +1612,9 @@ early_finish:
>
> err_did:
> ata_qc_free(qc);
> -err_mem:
> cmd->result = (DID_ERROR << 16);
> done(cmd);
> +err_mem:
> DPRINTK("EXIT - internal\n");
> return 0;
Yep, that looks like a bug (and correct fix)
I'll queue it, but let me know results from your testing regardless.
Jeff
next prev parent reply other threads:[~2006-11-12 19:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4D0A3E3121A0504EAEF0FBA7B9576C2608015A07@toroondc914.bell.corp.bce.ca>
2006-11-10 23:53 ` Aic94xx and Linux kernel 2.6.19 Darrick J. Wong
2006-11-11 1:21 ` Luben Tuikov
2006-11-12 19:05 ` Darrick J. Wong
2006-11-12 19:23 ` Jeff Garzik [this message]
2006-11-14 1:53 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45577499.1010101@garzik.org \
--to=jeff@garzik.org \
--cc=James.Bottomley@SteelEye.com \
--cc=alexisb@us.ibm.com \
--cc=djwong@us.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=ltuikov@yahoo.com \
--cc=mike.redan@bell.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox