* [PATCH] sas_ata: don't copy aic94xx's sactive to ata_port
@ 2006-11-14 18:29 Darrick J. Wong
0 siblings, 0 replies; only message in thread
From: Darrick J. Wong @ 2006-11-14 18:29 UTC (permalink / raw)
To: linux-scsi, Linux Kernel Mailing List; +Cc: Alexis Bruemmer
Since the aic94xx sequencer assigns its own NCQ tags to ATA commands, it
no longer makes any sense to copy the sactive field in the STP response
to ata_port->sactive, as that will confuse libata. Also, libata seems
to be capable of managing sactive on its own.
The attached patch gets rid of one of the causes of the BUG messages in
ata_qc_new, and should apply against jejb's aic94xx-sas git tree.
--
Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c
index ca49d3e..9580d81 100644
--- a/drivers/scsi/libsas/sas_ata.c
+++ b/drivers/scsi/libsas/sas_ata.c
@@ -108,7 +108,6 @@ static void sas_ata_task_done(struct sas
dev->sata_dev.sstatus = resp->sstatus;
dev->sata_dev.serror = resp->serror;
dev->sata_dev.scontrol = resp->scontrol;
- dev->sata_dev.ap->sactive = resp->sactive;
} else if (stat->stat != SAM_STAT_GOOD) {
ac = sas_to_ata_err(stat);
if (ac) {
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2006-11-14 18:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-14 18:29 [PATCH] sas_ata: don't copy aic94xx's sactive to ata_port Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox