Re: Spinup of SCSI Disks: allow_restart won't work on 2.6.18

James Bottomley
2006-11-21T04:22:57Z

On Mon, 2006-11-20 at 19:54 -0500, Douglas Gilbert wrote:
> ... but why have the condition at all? What other peripheral
> device type should the _sd_ driver be handling??

The original patch was for some IBM ipr array that behaves stupidly and
requires a START_UNIT after a reset. I suspect this was the reason the
type check was in there. However, if there's a use for this outside the
particular array, then it should be taken out.

Note that there may be a bit of work necessary to make this function for
USB: it's keyed to the standard response CC/UA/LOGICAL UNIT NOT READY,
INITIALIZING COMMAND REQUIRED. Since USB devices aren't necessarily
standards compliant in this regard, simply setting the bit may not work.

James