Re: Spinup of SCSI Disks: allow_restart won't work on 2.6.18

Stefan Richter
2006-11-21T08:13:08Z

James Bottomley wrote:
> On Mon, 2006-11-20 at 19:54 -0500, Douglas Gilbert wrote:
>> ... but why have the condition at all? What other peripheral
>> device type should the _sd_ driver be handling??

Of course. Check the time stamp of my posting. #-)

> The original patch was for some IBM ipr array that behaves stupidly and
> requires a START_UNIT after a reset. I suspect this was the reason the
> type check was in there. However, if there's a use for this outside the
> particular array, then it should be taken out.

Enabling this feature for RBC devices too is not a big deal. As
mentioned earlier in the thread, sbp2 sets the respective flag to 1 for
all devices now, so this change would allow to switch this back off. I
don't anticipate actual need to ever switch it off though.

> Note that there may be a bit of work necessary to make this function for
> USB: it's keyed to the standard response CC/UA/LOGICAL UNIT NOT READY,
> INITIALIZING COMMAND REQUIRED. Since USB devices aren't necessarily
> standards compliant in this regard, simply setting the bit may not work.
--
Stefan Richter
-=====-=-==- =-== =-=-=