From: Michael Reed <mdr@sgi.com>
To: ltuikov@yahoo.com
Cc: Andrew Morton <akpm@osdl.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: Infinite retries reading the partition table
Date: Tue, 05 Dec 2006 14:40:49 -0600 [thread overview]
Message-ID: <4575D951.3010705@sgi.com> (raw)
In-Reply-To: <520003.85125.qm@web31807.mail.mud.yahoo.com>
Luben Tuikov wrote:
...snip...
> This statement in scsi_io_completion() causes the infinite retry loop:
> if (scsi_end_request(cmd, 1, good_bytes, !!result) == NULL)
> return;
The code in 2.6.19 is "result==0", not "!!result", which is logically
the same as "result!=0". Did you mean to change the logic here?
Am I missing something?
Mike
next prev parent reply other threads:[~2006-12-05 20:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-30 1:22 Infinite retries reading the partition table Luben Tuikov
2006-12-01 5:47 ` Andrew Morton
2006-12-01 6:34 ` Luben Tuikov
2006-12-01 7:29 ` Andrew Morton
2006-12-01 8:32 ` Luben Tuikov
2006-12-05 20:40 ` Michael Reed [this message]
2006-12-06 5:00 ` Luben Tuikov
2006-12-06 5:08 ` Andrew Morton
2006-12-06 6:10 ` Luben Tuikov
2006-12-06 15:59 ` James Bottomley
2006-12-06 20:24 ` Luben Tuikov
2006-12-07 18:16 ` James Bottomley
2006-12-07 19:14 ` Luben Tuikov
2006-12-07 21:15 ` James Bottomley
2006-12-06 10:48 ` Etienne.Vogt
-- strict thread matches above, loose matches on Subject: below --
2006-11-30 1:53 Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4575D951.3010705@sgi.com \
--to=mdr@sgi.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ltuikov@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox