public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Douglas Gilbert <dougg@torque.net>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: linux1394-devel@lists.sourceforge.net, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] ieee1394: sbp2: pass REQUEST_SENSE through to the target
Date: Thu, 28 Dec 2006 15:21:45 -0500	[thread overview]
Message-ID: <45942759.8080804@torque.net> (raw)
In-Reply-To: <tkrat.9e24970727f8c664@s5r6.in-berlin.de>

Stefan Richter wrote:
> Delete some incorrect code, left over from the initial driver submission
> in March 2001.
> 
> SBP-2 targets should provide sense data via the SBP-2 status block
> (autosense).  We have to pass the REQUEST_SENSE command through to
> targets which don't implement autosense, if there are any.

Umm, REQUEST SENSE has several other useful capabilities.
It can convey information about low power conditions,
a progress indicator (e.g. during FORMAT with IMMED=1)
and informational exception warnings. It is also
defined to work any time INQUIRY works (e.g. on lun=0
when there is no lu there but there is a lun>0).

smartmontools sets MRIE to 6 in the control mode page so
it can periodically poll a disk with REQUEST SENSE to see
if it has tripped a threshold . It could use other techniques
but they would most likely interfere with normal error
processing on the host OS (and linux is one of about 8).

So, this patch is a step in the right direction.
Hopefully not too many other LLDs are playing
games with REQUEST SENSE.

Doug Gilbert

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

  reply	other threads:[~2006-12-28 20:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-28 18:57 [PATCH] ieee1394: sbp2: pass REQUEST_SENSE through to the target Stefan Richter
2006-12-28 20:21 ` Douglas Gilbert [this message]
2006-12-28 20:54   ` Matthew Wilcox
2006-12-28 22:38   ` Stefan Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45942759.8080804@torque.net \
    --to=dougg@torque.net \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=stefanr@s5r6.in-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox