Re: [PATCH] ieee1394: sbp2: pass REQUEST_SENSE through to the target

Matthew Wilcox
2006-12-28T20:54:06Z

On Thu, Dec 28, 2006 at 03:21:45PM -0500, Douglas Gilbert wrote:
> So, this patch is a step in the right direction.
> Hopefully not too many other LLDs are playing
> games with REQUEST SENSE.

A lot of drivers play games with REQUEST_SENSE, but they mostly seem to
be doing things with their own internal state. One suspicious one is
BusLogic.c :

/*
SCSI REQUEST_SENSE commands will be executed automatically by the Host
Adapter for any errors, so they should not be executed explicitly unless
the Sense Data is zero indicating that no error occurred.
*/
if (CDB[0] == REQUEST_SENSE && Command->sense_buffer[0] != 0) {
Command->result = DID_OK << 16;
CompletionRoutine(Command);
return 0;
}

I don't know if this is OK for your scenario or not.