From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kirill Korotaev Subject: Re: [PATCH 0/59] Cleanup sysctl Date: Wed, 17 Jan 2007 21:10:50 +0300 Message-ID: <45AE66AA.1050508@sw.ru> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org To: "Eric W. Biederman" Cc: Andrew Morton , James.Bottomley@SteelEye.com, linux-mips@linux-mips.org, linux-parport@lists.infradead.org, minyard@acm.org, rtc-linux@googlegroups.com, clemens@ladisch.de, heiko.carstens@de.ibm.com, xfs@oss.sgi.com, linuxppc-dev@ozlabs.org, paulus@samba.org, openipmi-developer@lists.sourceforge.net, linux-390@vm.marist.edu, schwidefsky@de.ibm.com, tim@cyberelk.net, codalist@TELEMANN.coda.cs.cmu.edu, a.zummo@towertech.it, tony.luck@intel.com, vojtech@suse.cz, linux-scsi@vger.kernel.org, xfs-masters@oss.sgi.com, linux-ntfs-dev@lists.sourceforge.net, netdev@vger.kernel.org, aia21@cantab.net, aharkes@cs.cmu.edu, linux-kernel@vger.kernel.org, ralf@linux-mips.org, mark.fasheh@oracle.com, coda@cs.cmu.edu, lethal@linux-sh.org, kurt.hackel@oracle.com, Linux Containers , linux390@de.ibm.com, philb@gnu.org, andrea@suse.de, linuxsh-shmed List-Id: linux-scsi@vger.kernel.org Eric, really good job! Patches: 1-13, 15-24, 26-32, 34-44, 46-49, 52-55, 57 (all except below) Acked-By: Kirill Korotaev 14/59 - minor (extra space) 25/59 - minor note 33/59 - not sorted sysctl IDs 45/59 - typo 50/59 - copyright/file note 51/59 - copyright/file name/kconfig option notes 56,58,59/59 - will review tomorrow another issue I have to think over is removal of de->owner. Alexey Dobriyan has sent recently patching fixing /proc <-> modules refcounting. I guess w/o these patches your changes are not safe if proc_handler or strategy are functions from the module. Thanks, Kirill > There has not been much maintenance on sysctl in years, and as a result is > there is a lot to do to allow future interesting work to happen, and being > ambitious I'm trying to do it all at once :) > > The patches in this series fall into several general categories. > > - Removal of useless attempts to override the standard sysctls > > - Registers of sysctl numbers in sysctl.h so someone else does not use > the magic number and conflict. > > - C99 conversions so it becomes possible to change the layout of > struct ctl_table without breaking everything. > > - Removal of useless claims of module ownership, in the proc dir entries > > - Removal of sys_sysctl support where people had used conflicting sysctl > numbers. Trying to break glibc or other applications by changing the > ABI is not cool. 9 instances of this in the kernel seems a little > extreme. > > - General enhancements when I got the junk I could see out. > > Odds are I missed something, most of the cleanups are simply a result of > me working on the sysctl core and glancing at the users and going: What? > > Eric > _______________________________________________ > Containers mailing list > Containers@lists.osdl.org > https://lists.osdl.org/mailman/listinfo/containers > >