[PATCH 0/7] Roll-up of libsas and aic94xx patches

[PATCH 0/7] Roll-up of libsas and aic94xx patches

[Darrick J. Wong]

Hi all,

This is a roll-up of all of my uncommitted patches against libsas
and aic94xx to date.  The first patch features an important fix for an
incorrect port deformation after a phy reset event.  The next two
patches in this set complete the reorganization of the
sas_rphy_{delete,free} calls after errors during discovery.  The next
two patches amend the SAS error handler to be able to handle scsi_cmnds
that have completed successfully but with a failure code, first by
trying START UNIT if the disk is not spinning, second by trying to
reset the device, and finally offlining the device if nothing works.
The last patch of the set enables auto-restart of SAS disks.

These patches should apply in number order cleanly against 2.6.20-rc6 +
scsi_misc + scsi-rc-fixes.  We've been running insmod/rmmod and pounder
tests on x260, x206m and x366 machines for a couple of days without
problems (albeit against 2.6.20-rc5).  Hopefully these patches are
ready for more widespread testing in scsi-misc, and thank you for any
comments or feedback that you provide.

(Apologies for any stgit mail misconfiguration on my part.)

--D

Re: [PATCH 0/7] Roll-up of libsas and aic94xx patches

[Douglas Gilbert]

Darrick J. Wong wrote:
> Hi all,
> 
> This is a roll-up of all of my uncommitted patches against libsas
> and aic94xx to date.  The first patch features an important fix for an
> incorrect port deformation after a phy reset event.  The next two
> patches in this set complete the reorganization of the
> sas_rphy_{delete,free} calls after errors during discovery.  The next
> two patches amend the SAS error handler to be able to handle scsi_cmnds
> that have completed successfully but with a failure code, first by
> trying START UNIT if the disk is not spinning, second by trying to
> reset the device, and finally offlining the device if nothing works.

Darrick,
The "reset the device" is a bit vague. Would that
be a LU reset (task management function) or a
"hard reset"? If the latter then it will cause
collateral damage if the target contains multiple
logical units (i.e. it will reset all of them,
not just the one failing to spin up).

Doug Gilbert

Re: [PATCH 0/7] Roll-up of libsas and aic94xx patches

[Darrick J. Wong]

Douglas Gilbert wrote:

> Darrick,
> The "reset the device" is a bit vague. Would that
> be a LU reset (task management function) or a
> "hard reset"? If the latter then it will cause
> collateral damage if the target contains multiple
> logical units (i.e. it will reset all of them,
> not just the one failing to spin up).

It's a hard reset.  After talking to Mike Anderson, it seems that
device_reset => LU reset and bus reset => phy reset are more appropriate
for SAS.  Will post patch shortly.

--D