From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Lord Subject: Re: [PATCH] scsi_lib.c: continue after MEDIUM_ERROR Date: Tue, 30 Jan 2007 20:36:02 -0500 Message-ID: <45BFF282.4050305@rtr.ca> References: <200701301947.08478.liml@rtr.ca> <1170206199.10890.13.camel@mulgrave.il.steeleye.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1170206199.10890.13.camel@mulgrave.il.steeleye.com> Sender: linux-ide-owner@vger.kernel.org To: James Bottomley Cc: linux-kernel@vger.kernel.org, IDE/ATA development list , linux-scsi List-Id: linux-scsi@vger.kernel.org James Bottomley wrote: > First off, please send SCSI patches to the SCSI list: > Fixed already, thanks! >> This patch fixes the behaviour to be similar to what we had originally. >> >> When a bad sector is encounted, SCSI will now work around it again, >> failing *only* the bad sector itself. > > Erm, but the corollary is that if we get a large read failure because of > a bad track, you're going to try and chunk up it a sector at a time That's better than the huge data-loss scenario that we currently have for single-sector errors. MUCH better. > forcing an individual error for each sector is going to annoy some > people ... particularly removable medium ones which return this error if > the medium isn't present ... Are you sure this is really what we want to > do? No, for removed-medium everything just fails right away. This patch is *only* for media errors, not any other failures. Cheers