From: Tejun Heo <htejun@gmail.com>
To: "Darrick J. Wong" <djwong@us.ibm.com>
Cc: linux-scsi@vger.kernel.org, alexisb@us.ibm.com
Subject: Re: [PATCH 08/12] libsas: Unknown STP devices should be reported to libata as unknown.
Date: Wed, 07 Feb 2007 00:20:50 -0800 [thread overview]
Message-ID: <45C98BE2.5060608@gmail.com> (raw)
In-Reply-To: <20070130091852.31530.20090.stgit@elm3a70.beaverton.ibm.com>
Darrick J. Wong wrote:
> When libsas encounters a STP device whose protocol isn't recognized (i.e.
> not ATA or ATAPI), we should set the ata_device's class to ATA_DEV_UNKNOWN
> instead of ATA_DEV_ATA.
>
> Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
> ---
>
> drivers/scsi/libsas/sas_ata.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c
> index 20f3a5e..7ebda69 100644
> --- a/drivers/scsi/libsas/sas_ata.c
> +++ b/drivers/scsi/libsas/sas_ata.c
> @@ -232,7 +232,7 @@ static void sas_ata_phy_reset(struct ata
> SAS_DPRINTK("%s: Unknown SATA command set: %d.\n",
> __FUNCTION__,
> dev->sata_dev.command_set);
> - ap->device[0].class = ATA_DEV_ATA;
> + ap->device[0].class = ATA_DEV_UNKNOWN;
ATA_DEV_UNKNOWN currently indicates 'unclassified' state and leaving
device as unclassified after successful reset is considered failure, so
this is a bit confusing but you need to return ATA_DEV_NONE here.
Hmmm... maybe libata should use ATA_DEV_UNCLASSIFIED instead.
--
tejun
next prev parent reply other threads:[~2007-02-07 17:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070130091814.31530.23152.stgit@elm3a70.beaverton.ibm.com>
2007-01-30 9:18 ` [PATCH 01/12] sas_ata: Require CONFIG_ATA in Kconfig Darrick J. Wong
2007-01-30 9:18 ` [PATCH 02/12] sas_ata: Satisfy libata qc function locking requirements Darrick J. Wong
2007-01-30 9:18 ` [PATCH 03/12] sas_ata: sas_ata_qc_issue should return AC_ERR_* Darrick J. Wong
2007-01-30 9:18 ` [PATCH 04/12] sas_ata: ata_post_internal should abort the sas_task Darrick J. Wong
2007-02-07 7:47 ` Tejun Heo
2007-02-22 21:39 ` [PATCH 1/2] sas_ata: Rename ata_queued_cmd->lldd_task to driver_data Darrick J. Wong
2007-02-22 21:43 ` Jeff Garzik
2007-02-22 21:39 ` [PATCH 2/2]: sas_ata: Don't reset the phy in post_internal_command Darrick J. Wong
2007-01-30 9:18 ` [PATCH 05/12] sas_ata: Don't copy aic94xx's sactive to ata_port Darrick J. Wong
2007-01-30 9:18 ` [PATCH 06/12] sas_ata: Implement SATA PHY control Darrick J. Wong
2007-02-07 7:54 ` Tejun Heo
2007-01-30 9:18 ` [PATCH 07/12] libsas: Accept SAM_GOOD for ATAPI devices in sas_ata_task_done Darrick J. Wong
2007-01-30 9:18 ` [PATCH 08/12] libsas: Unknown STP devices should be reported to libata as unknown Darrick J. Wong
2007-02-07 8:20 ` Tejun Heo [this message]
2007-01-30 9:18 ` [PATCH 09/12] sas_ata: Assign sas_task to scsi_cmnd to enable EH for ATA devices Darrick J. Wong
2007-01-30 9:18 ` [PATCH 10/12] sas_ata: Implement sas_task_abort " Darrick J. Wong
2007-01-30 9:19 ` [PATCH 11/12] libsas: Provide a generic SATL registration function Darrick J. Wong
2007-01-30 9:19 ` [PATCH 12/12] sas_ata: Make this a module separate from libsas Darrick J. Wong
2007-02-03 16:03 ` James Bottomley
2007-02-04 9:06 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45C98BE2.5060608@gmail.com \
--to=htejun@gmail.com \
--cc=alexisb@us.ibm.com \
--cc=djwong@us.ibm.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox