Re: aic79xx noise on hot insert in 2.6.19.x and 2.6.20

[Hannes Reinecke <hare@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 1210 bytes --]

Darrick J. Wong wrote:
> Mark Rustad wrote:
>> I have systems with Supermicro X6-class (Nocona/Lindenhurst)
>> motherboards with Adaptec SCSI and SAFTE backplanes running software
>> RAID-1 (md) on a pair of drives. When I hot-insert a drive, I get a lot
>> of noise from the kernel apparently due to lack of handling something in
>> the interrupt routine. So far, life seems to go on after the event, but
>> not knowing anything about the internals of the driver, I am concerned
>> enough to want to ask about it.
> 
> I see the noise too, though I don't know enough about aic79xx (and am
> too busy with aic94xx) to do anything about it.  As far as I can tell,
> the driver's just being a little trigger happy with the "DUMP CARD
> STATE" routine.  But that's my totally unqualified opinion. :)
> 
Yeah, that's default behaviour with aic79xx. First complain and then
check if it actually was an error.

But anyway, looks like it was actually my fault. Might be an idea to
clear the bus reset flag again.

Care to try the attached patch?

Cheers,

Hannes
-- 
Dr. Hannes Reinecke			hare@suse.de
SuSE Linux Products GmbH		S390 & zSeries
Maxfeldstraße 5				+49 911 74053 688
90409 Nürnberg				http://www.suse.de

[-- Attachment #2: aic79xx-clear-bus-reset-flag --]
[-- Type: text/plain, Size: 443 bytes --]

diff --git a/drivers/scsi/aic7xxx/aic79xx_core.c b/drivers/scsi/aic7xxx/aic79xx_core.c
index 07a86a3..bf073d2 100644
--- a/drivers/scsi/aic7xxx/aic79xx_core.c
+++ b/drivers/scsi/aic7xxx/aic79xx_core.c
@@ -1645,6 +1645,7 @@ ahd_handle_scsiint(struct ahd_softc *ahd
 	 */
 	if (((status & SCSIRSTI) != 0) && (ahd->flags & AHD_BUS_RESET_ACTIVE)) {
 		ahd_outb(ahd, CLRSINT1, CLRSCSIRSTI);
+		ahd->flags &= ~AHD_BUS_RESET_ACTIVE;
 		return;
 	}