From: Douglas Gilbert <dougg@torque.net>
To: Jeff Garzik <jeff@garzik.org>
Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
linux-scsi@vger.kernel.org, jens.axboe@oracle.com,
James.Smart@Emulex.Com, hch@infradead.org
Subject: Re: [PATCH] bind bsg to request_queue instead of gendisk
Date: Wed, 14 Feb 2007 06:07:44 -0800 [thread overview]
Message-ID: <45D317B0.7020100@torque.net> (raw)
In-Reply-To: <20070213180033.GB6798@havoc.gtf.org>
Jeff Garzik wrote:
> On Wed, Feb 14, 2007 at 02:53:31AM +0900, FUJITA Tomonori wrote:
>> It seems that it would be better to bind bsg devices to request_queue
>> instead of gendisk. This enables any objects to define own
>> request_handler and create own bsg device (under sysfs).
>>
>> Possible enhancements:
>>
>> - I removed gendisk but it would be better for objects having gendisk
>> to keep it for nice features like disk stats.
>>
>> - Objects that wants to use bsg need to setup a request_queue. Maybe
>> wrapper functions to setup a request_queue for them would be useful.
>>
>> This patch was tested only with disk drivers.
>>
>>
>> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
>> ---
>> block/bsg.c | 37 +++++++++++++++++--------------------
>
> What is this patch against? scsi-misc?
>
> I certainly like the bsg solution, but block/bsg.c does not exist in my
> vanilla linux-2.6.git tree :)
www.kernel.org/pub/scm/linux/kernel/git/axboe/linux-2.6-block.git
branch: bsg
next prev parent reply other threads:[~2007-02-14 14:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-13 17:53 [PATCH] bind bsg to request_queue instead of gendisk FUJITA Tomonori
2007-02-13 18:00 ` Jeff Garzik
2007-02-14 14:07 ` Douglas Gilbert [this message]
2007-02-15 2:13 ` FUJITA Tomonori
2007-02-14 20:56 ` Pete Wyckoff
2007-02-14 21:14 ` James Smart
2007-02-14 21:25 ` Jens Axboe
2007-03-19 10:25 ` FUJITA Tomonori
2007-03-19 19:03 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45D317B0.7020100@torque.net \
--to=dougg@torque.net \
--cc=James.Smart@Emulex.Com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=hch@infradead.org \
--cc=jeff@garzik.org \
--cc=jens.axboe@oracle.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).